You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/09 00:27:26 UTC
[GitHub] [spark] gengliangwang opened a new pull request, #37841: [SPARK-40324][SQL] Provide query context in AnalysisException
gengliangwang opened a new pull request, #37841:
URL: https://github.com/apache/spark/pull/37841
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This is a major PR for extending AnalysisException with query context. After changes, we can:
* migrate analysis errors to error classes
* change the actual error messages of AnalysisException, showing the query context from original query instead of an unresolved logical plan.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Make it possible for better error messages in analysis exceptions.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No. This is an extension of the framework. We will have more improvements based on this one.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Existing UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #37841: [SPARK-40324][SQL] Provide query context in AnalysisException
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #37841:
URL: https://github.com/apache/spark/pull/37841#discussion_r966744144
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/AnalysisException.scala:
##########
@@ -124,12 +126,16 @@ class AnalysisException protected[sql] (
plan: Option[LogicalPlan] = this.plan,
cause: Option[Throwable] = this.cause,
errorClass: Option[String] = this.errorClass,
- messageParameters: Array[String] = this.messageParameters): AnalysisException =
+ messageParameters: Array[String] = this.messageParameters,
+ context: Array[QueryContext] = Array.empty): AnalysisException =
new AnalysisException(message, line, startPosition, plan, cause, errorClass, errorSubClass,
- messageParameters)
+ messageParameters, context)
- def withPosition(line: Option[Int], startPosition: Option[Int]): AnalysisException = {
- val newException = this.copy(line = line, startPosition = startPosition)
+ def withPosition(origin: Origin): AnalysisException = {
+ val newException = this.copy(
+ line = origin.line,
+ startPosition = origin.startPosition,
Review Comment:
oh we still need them, for errors without error classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #37841: [SPARK-40324][SQL] Provide query context in AnalysisException
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #37841:
URL: https://github.com/apache/spark/pull/37841#discussion_r966738071
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/ExpressionTypeCheckingSuite.scala:
##########
@@ -77,12 +77,6 @@ class ExpressionTypeCheckingSuite extends SparkFunSuite with SQLHelper {
}
test("check types for binary arithmetic") {
- // We will cast String to Double for binary arithmetic
- assertSuccess(Add($"intField", $"stringField"))
- assertSuccess(Subtract($"intField", $"stringField"))
- assertSuccess(Multiply($"intField", $"stringField"))
- assertSuccess(Divide($"intField", $"stringField"))
- assertSuccess(Remainder($"intField", $"stringField"))
Review Comment:
why remove these?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #37841: [SPARK-40324][SQL] Provide query context in AnalysisException
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #37841: [SPARK-40324][SQL] Provide query context in AnalysisException
URL: https://github.com/apache/spark/pull/37841
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dtenedor commented on pull request #37841: [SPARK-40324][SQL] Provide query context in AnalysisException
Posted by GitBox <gi...@apache.org>.
dtenedor commented on PR #37841:
URL: https://github.com/apache/spark/pull/37841#issuecomment-1242354926
cc @dtenedor myself for context
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #37841: [SPARK-40324][SQL] Provide query context in AnalysisException
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #37841:
URL: https://github.com/apache/spark/pull/37841#issuecomment-1242747704
+1, LGTM. Merging to master.
Thank you, @gengliangwang and @cloud-fan for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a diff in pull request #37841: [SPARK-40324][SQL] Provide query context in AnalysisException
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on code in PR #37841:
URL: https://github.com/apache/spark/pull/37841#discussion_r967326002
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/ExpressionTypeCheckingSuite.scala:
##########
@@ -77,12 +77,6 @@ class ExpressionTypeCheckingSuite extends SparkFunSuite with SQLHelper {
}
test("check types for binary arithmetic") {
- // We will cast String to Double for binary arithmetic
- assertSuccess(Add($"intField", $"stringField"))
- assertSuccess(Subtract($"intField", $"stringField"))
- assertSuccess(Multiply($"intField", $"stringField"))
- assertSuccess(Divide($"intField", $"stringField"))
- assertSuccess(Remainder($"intField", $"stringField"))
Review Comment:
Removed by mistake. It is recovered now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #37841: [SPARK-40324][SQL] Provide query context in AnalysisException
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #37841:
URL: https://github.com/apache/spark/pull/37841#discussion_r966737035
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/AnalysisException.scala:
##########
@@ -124,12 +126,16 @@ class AnalysisException protected[sql] (
plan: Option[LogicalPlan] = this.plan,
cause: Option[Throwable] = this.cause,
errorClass: Option[String] = this.errorClass,
- messageParameters: Array[String] = this.messageParameters): AnalysisException =
+ messageParameters: Array[String] = this.messageParameters,
+ context: Array[QueryContext] = Array.empty): AnalysisException =
new AnalysisException(message, line, startPosition, plan, cause, errorClass, errorSubClass,
- messageParameters)
+ messageParameters, context)
- def withPosition(line: Option[Int], startPosition: Option[Int]): AnalysisException = {
- val newException = this.copy(line = line, startPosition = startPosition)
+ def withPosition(origin: Origin): AnalysisException = {
+ val newException = this.copy(
+ line = origin.line,
+ startPosition = origin.startPosition,
Review Comment:
do we still need the `line` and `startPosition` parameters?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #37841: [SPARK-40324][SQL] Provide query context in AnalysisException
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on PR #37841:
URL: https://github.com/apache/spark/pull/37841#issuecomment-1241364233
cc @srielau @anchovYu as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org