[jira] [Comment Edited] (BEAM-4704) String operations yield incorrect results when executed through SQL shell

["Kenneth Knowles (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-4704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529370#comment-16529370 ] 

Kenneth Knowles edited comment on BEAM-4704 at 7/2/18 4:14 AM:
---------------------------------------------------------------

[~apilloud] -wild- confident guess here - the shell only invokes our code when the calling convention insists that it do so.


was (Author: kenn):
[~apilloud] wild guess here - the shell only invokes our code when the calling convention insists that it do so?

> String operations yield incorrect results when executed through SQL shell
> -------------------------------------------------------------------------
>
>                 Key: BEAM-4704
>                 URL: https://issues.apache.org/jira/browse/BEAM-4704
>             Project: Beam
>          Issue Type: Bug
>          Components: dsl-sql
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>            Priority: Major
>
> {{TRIM}} is defined to trim _all_ the characters in the first string from the string-to-be-trimmed. Calcite has an incorrect implementation of this. We use our own fixed implementation. But when executed through the SQL shell, the results do not match what we get from the PTransform path. Here two test cases that pass on {{master}} but are incorrect in the shell:
> {code:sql}
> BeamSQL> select TRIM(LEADING 'eh' FROM 'hehe__hehe');
> +------------+
> | EXPR$0 |
> +------------+
> | hehe__hehe |
> +------------+
> {code}
> {code:sql}
> BeamSQL> select TRIM(TRAILING 'eh' FROM 'hehe__hehe');
> +------------+
> |   EXPR$0   |
> +------------+
> | hehe__heh  |
> +------------+
> {code}
> {code:sql}
> BeamSQL> select TRIM(BOTH 'eh' FROM 'hehe__hehe');
> +------------+
> |   EXPR$0   |
> +------------+
> | hehe__heh  |
> +------------+
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)