You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/11/09 13:26:49 UTC

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6877: Fix typos and improve javadocs on ByteScaleUtils

DaanHoogland commented on code in PR #6877:
URL: https://github.com/apache/cloudstack/pull/6877#discussion_r1017935778


##########
utils/src/main/java/org/apache/cloudstack/utils/bytescale/ByteScaleUtils.java:
##########
@@ -27,32 +27,32 @@ public class ByteScaleUtils {
     private ByteScaleUtils() {}
 
     /**
-     * Converts mebibytes to bytes.
+     * Converts mebibyte to bytes.
      *
      * @param mib The value to convert to bytes (eq: 1, 2, 3, ..., 42,...).
-     * @return The parameter multiplied by 1048576 (1024 * 1024, 1 MiB).
+     * @return The parameter multiplied by 2²⁰ (1048576 | 1024 * 1024 | 1 MiB | ).
      */
     public static long mibToBytes(long mib) {

Review Comment:
   I like @GutoVeronezi 's last proposal here, reading will actually be quicker as you don´t need to translate in your head.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org