[jira] [Commented] (HIVE-22099) Several date related UDFs can't handle Julian dates properly since HIVE-20007

["Jesus Camacho Rodriguez (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-22099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16921542#comment-16921542 ] 

Jesus Camacho Rodriguez commented on HIVE-22099:
------------------------------------------------

[~szita], a few minor comments on the patch. Consider using {{DateTimeMath.retrieveProlepticGregorianCalendarUTC}} instead of importing the static method. Also {{retrieveProlepticGregorianCalendarUTC}} -> {{getProlepticGregorianCalendarUTC}}.

> Several date related UDFs can't handle Julian dates properly since HIVE-20007
> -----------------------------------------------------------------------------
>
>                 Key: HIVE-22099
>                 URL: https://issues.apache.org/jira/browse/HIVE-22099
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Adam Szita
>            Assignee: Adam Szita
>            Priority: Major
>         Attachments: HIVE-22099.0.patch, HIVE-22099.1.patch, HIVE-22099.2.patch, HIVE-22099.3.patch, HIVE-22099.4.patch, HIVE-22099.5.patch
>
>
> Currently dates that belong to Julian calendar (before Oct 15, 1582) are handled improperly by date/timestamp UDFs.
> E.g. DateFormat UDF:
> Although the dates are in Julian calendar, the formatter insists to print these according to Gregorian calendar causing multiple days of difference in some cases:
>  
> {code:java}
> beeline> select date_format('1001-01-05','dd---MM--yyyy');
> +----------------+
> | _c0 |
> +----------------+
> | 30---12--1000 |
> +----------------+{code}
>  I've observed similar problems in the following UDFs:
>  * add_months
>  * date_format
>  * day
>  * month
>  * months_between
>  * weekofyear
>  * year
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)