You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/02/26 13:56:27 UTC
[GitHub] [incubator-pekko] mdedetrich opened a new pull request, #218: Test pr
mdedetrich opened a new pull request, #218:
URL: https://github.com/apache/incubator-pekko/pull/218
Test PR to see if header status check works
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #218: Test pr
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #218:
URL: https://github.com/apache/incubator-pekko/pull/218#discussion_r1118094862
##########
.asf.yaml:
##########
@@ -35,6 +35,13 @@ github:
# contexts are the names of checks that must pass
contexts:
- Code is formatted
+ temp:
+ required_status_checks:
+ # strict means "Require branches to be up to date before merging".
+ strict: false
+ # contexts are the names of checks that must pass
+ contexts:
+ - Check headers
Review Comment:
> markdown files
At least if we are talking about docs, readme afaik these do not require headers, its actually noted on ASF's legal site i.e. from https://www.apache.org/legal/src-headers.html#faq-exceptions
> Short informational text files; for example README, INSTALL files. The expectation is that these files make it obvious which product they relate to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich closed pull request #218: Test pr
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich closed pull request #218: Test pr
URL: https://github.com/apache/incubator-pekko/pull/218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #218: Test pr
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #218:
URL: https://github.com/apache/incubator-pekko/pull/218#discussion_r1118091813
##########
.asf.yaml:
##########
@@ -35,6 +35,13 @@ github:
# contexts are the names of checks that must pass
contexts:
- Code is formatted
+ temp:
+ required_status_checks:
+ # strict means "Require branches to be up to date before merging".
+ strict: false
+ # contexts are the names of checks that must pass
+ contexts:
+ - Check headers
Review Comment:
I understand the sentiment behind the concern but I am not exactly sure how its going to be a technical problem. If any supposed improvements to the header checks cause the check to fail then such a PR wouldn't get merged anyways unless we are going to tell people to ignore the now failing header check, and if so in such a case we would temporarily disable the entire header pipeline along with the check in a separate PR.
The alternative situation is that the header check just doesn't pick up everything (which is the current case, i.e. sbt-header is not picking headers from sbt project files in `project/`) in which case its not going to block anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #218: Test pr
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #218:
URL: https://github.com/apache/incubator-pekko/pull/218#discussion_r1118091813
##########
.asf.yaml:
##########
@@ -35,6 +35,13 @@ github:
# contexts are the names of checks that must pass
contexts:
- Code is formatted
+ temp:
+ required_status_checks:
+ # strict means "Require branches to be up to date before merging".
+ strict: false
+ # contexts are the names of checks that must pass
+ contexts:
+ - Check headers
Review Comment:
I understand the sentiment behind the concern but I am not exactly sure how its going to be a technical problem. If any supposed improvements to the header checks cause the check to fail then such a PR wouldn't get merged anyways unless we are going to tell people to ignore the now failing header check, and hence in such a case we would more likely temporarily disable the entire header workflow action along with the header check in a separate PR.
The alternative situation is that the header check just doesn't pick up everything (which is the current case, i.e. sbt-header is not picking headers from sbt project files in `project/`) in which case its not going to block anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #218: Test pr
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #218:
URL: https://github.com/apache/incubator-pekko/pull/218#discussion_r1118091813
##########
.asf.yaml:
##########
@@ -35,6 +35,13 @@ github:
# contexts are the names of checks that must pass
contexts:
- Code is formatted
+ temp:
+ required_status_checks:
+ # strict means "Require branches to be up to date before merging".
+ strict: false
+ # contexts are the names of checks that must pass
+ contexts:
+ - Check headers
Review Comment:
I understand the sentiment behind the concern but I am not exactly sure how its going to be a technical problem. If any supposed improvements to the header checks cause the check to fail then such a PR wouldn't get merged anyways unless we are going to tell people to ignore the now failing header check, and hence in such a case we would temporarily disable the entire header workflow action along with the check in a separate PR.
The alternative situation is that the header check just doesn't pick up everything (which is the current case, i.e. sbt-header is not picking headers from sbt project files in `project/`) in which case its not going to block anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #218: Test pr
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #218:
URL: https://github.com/apache/incubator-pekko/pull/218#discussion_r1118091218
##########
.asf.yaml:
##########
@@ -35,6 +35,13 @@ github:
# contexts are the names of checks that must pass
contexts:
- Code is formatted
+ temp:
+ required_status_checks:
+ # strict means "Require branches to be up to date before merging".
+ strict: false
+ # contexts are the names of checks that must pass
+ contexts:
+ - Check headers
Review Comment:
We have plenty of work to still do with adding headers - I'd prefer not to make the header check something that completely blocks merges. Humans need to approve PRs anyway. Can we wait till we have added headers everywhere we need them?
* probably conf files
* markdown files
* probably more file types too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #218: Test pr
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #218:
URL: https://github.com/apache/incubator-pekko/pull/218#discussion_r1118091813
##########
.asf.yaml:
##########
@@ -35,6 +35,13 @@ github:
# contexts are the names of checks that must pass
contexts:
- Code is formatted
+ temp:
+ required_status_checks:
+ # strict means "Require branches to be up to date before merging".
+ strict: false
+ # contexts are the names of checks that must pass
+ contexts:
+ - Check headers
Review Comment:
I understand the sentiment behind the concern but I am not exactly sure how its going to be a technical problem. If any supposed improvements to the header checks cause the check to fail then such a PR wouldn't get merged anyways unless we are going to tell people to ignore the now failing header check, and hence in such a case we would more likely temporarily disable the entire header workflow action along with the header check in a separate PR.
The alternative situation is that the header check just doesn't pick up everything (which is the current case, i.e. sbt-header is not picking headers from sbt project files in `project/`) in which case its not going to block anything, even if we add additional headers to other types of files (i.e. `conf` files). By default sbt-header only picks up scala/java files (and this is configurable anyways).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #218: Test pr
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #218:
URL: https://github.com/apache/incubator-pekko/pull/218#discussion_r1118096682
##########
.asf.yaml:
##########
@@ -35,6 +35,13 @@ github:
# contexts are the names of checks that must pass
contexts:
- Code is formatted
+ temp:
+ required_status_checks:
+ # strict means "Require branches to be up to date before merging".
+ strict: false
+ # contexts are the names of checks that must pass
+ contexts:
+ - Check headers
Review Comment:
I mean the markdown files used by paradox build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org