You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@click.apache.org by "Finn Bock (JIRA)" <ji...@apache.org> on 2009/08/24 22:14:59 UTC
[jira] Created: (CLK-577) The
The <label for=".."> for a RadioGroup in a Form references an non-existing id.
------------------------------------------------------------------------------
Key: CLK-577
URL: https://issues.apache.org/jira/browse/CLK-577
Project: Click
Issue Type: Bug
Affects Versions: 2.1.0 RC1
Reporter: Finn Bock
Priority: Minor
Using the example in the API docs for RadioGroup,
radioGroup.add(new Radio("STD", "Standard "));
radioGroup.add(new Radio("PRO", "Protective "));
radioGroup.add(new Radio("GFT", "Gift Wrap "));
radioGroup.setValue("STD");
radioGroup.setVerticalLayout(true);
form.add(radioGroup);
a <label for="form_packaging">Packaging</label> is generated, but the radiogroup only creates individual radio buttons with id like form_packaging_STD, form_packaging_PRO and form_packaging_GFT.
<td class="fields" align="left"><label for="form_packaging">Packaging</label> </td>
<td align="left">
<input type="radio" name="packaging" value="STD" id="form_packaging_STD" checked="checked"/><label for="form_packaging_STD">Standard </label><br/>
<input type="radio" name="packaging" value="PRO" id="form_packaging_PRO"/><label for="form_packaging_PRO">Protective </label><br/>
<input type="radio" name="packaging" value="GFT" id="form_packaging_GFT"/><label for="form_packaging_GFT">Gift Wrap </label>
</td>
I would guess that wrapping the list of Radio controls in a <div id="form_packaging">..</div> would solve the issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CLK-577) The
Posted by "Bob Schellink (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLK-577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bob Schellink updated CLK-577:
------------------------------
Fix Version/s: 2.2.0
Assignee: Bob Schellink
To remove the label we'll need to add a "instanceof RadioGroup" in Form to not render the label. Doesn't look like a good approach. As Finn suggested we need to wrap the radio controls in a container such as a div or a span. I'm leaning towards a span since div is a block level element and might break existing manual layouts.
> The <label for=".."> for a RadioGroup in a Form references an non-existing id.
> ------------------------------------------------------------------------------
>
> Key: CLK-577
> URL: https://issues.apache.org/jira/browse/CLK-577
> Project: Click
> Issue Type: Bug
> Affects Versions: 2.1.0 RC1
> Reporter: Finn Bock
> Assignee: Bob Schellink
> Priority: Minor
> Fix For: 2.2.0
>
>
> Using the example in the API docs for RadioGroup,
> radioGroup.add(new Radio("STD", "Standard "));
> radioGroup.add(new Radio("PRO", "Protective "));
> radioGroup.add(new Radio("GFT", "Gift Wrap "));
> radioGroup.setValue("STD");
> radioGroup.setVerticalLayout(true);
> form.add(radioGroup);
> a <label for="form_packaging">Packaging</label> is generated, but the radiogroup only creates individual radio buttons with id like form_packaging_STD, form_packaging_PRO and form_packaging_GFT.
> <td class="fields" align="left"><label for="form_packaging">Packaging</label> </td>
> <td align="left">
> <input type="radio" name="packaging" value="STD" id="form_packaging_STD" checked="checked"/><label for="form_packaging_STD">Standard </label><br/>
> <input type="radio" name="packaging" value="PRO" id="form_packaging_PRO"/><label for="form_packaging_PRO">Protective </label><br/>
> <input type="radio" name="packaging" value="GFT" id="form_packaging_GFT"/><label for="form_packaging_GFT">Gift Wrap </label>
> </td>
> I would guess that wrapping the list of Radio controls in a <div id="form_packaging">..</div> would solve the issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CLK-577) The
Posted by "Bob Schellink (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLK-577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751709#action_12751709 ]
Bob Schellink commented on CLK-577:
-----------------------------------
Hmm, probably better to remove the 'for' attribute from the first label. Since each radio button has its own label describing it, it should be ok.
> The <label for=".."> for a RadioGroup in a Form references an non-existing id.
> ------------------------------------------------------------------------------
>
> Key: CLK-577
> URL: https://issues.apache.org/jira/browse/CLK-577
> Project: Click
> Issue Type: Bug
> Affects Versions: 2.1.0 RC1
> Reporter: Finn Bock
> Priority: Minor
>
> Using the example in the API docs for RadioGroup,
> radioGroup.add(new Radio("STD", "Standard "));
> radioGroup.add(new Radio("PRO", "Protective "));
> radioGroup.add(new Radio("GFT", "Gift Wrap "));
> radioGroup.setValue("STD");
> radioGroup.setVerticalLayout(true);
> form.add(radioGroup);
> a <label for="form_packaging">Packaging</label> is generated, but the radiogroup only creates individual radio buttons with id like form_packaging_STD, form_packaging_PRO and form_packaging_GFT.
> <td class="fields" align="left"><label for="form_packaging">Packaging</label> </td>
> <td align="left">
> <input type="radio" name="packaging" value="STD" id="form_packaging_STD" checked="checked"/><label for="form_packaging_STD">Standard </label><br/>
> <input type="radio" name="packaging" value="PRO" id="form_packaging_PRO"/><label for="form_packaging_PRO">Protective </label><br/>
> <input type="radio" name="packaging" value="GFT" id="form_packaging_GFT"/><label for="form_packaging_GFT">Gift Wrap </label>
> </td>
> I would guess that wrapping the list of Radio controls in a <div id="form_packaging">..</div> would solve the issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.