You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/10/05 19:31:15 UTC

[GitHub] [helix] zhangmeng916 opened a new pull request #1436: Not to reuse data accessor in Helix customized state provider

zhangmeng916 opened a new pull request #1436:
URL: https://github.com/apache/helix/pull/1436


   ### Issues
   
   - [X] My PR addresses the following Helix issues and references them in the PR description:
   
   Fixed #1435 
   
   ### Description
   
   - [X] Here are some details about my PR, including screenshots of any UI changes:
   
   In customized state provider, there is a local variable of Helix data accessor, which is get from Helix manager. When Helix manager disconnect and reconnect, the data accessor actually causes some stale data to exist. This PR removes Helix data accessor from customized state provider.
   
   ### Tests
   
   - [ ] The following tests are written for this issue:
   
   (List the names of added unit/integration tests)
   
   - [ ] The following is the result of the "mvn test" command on the appropriate module:
   
   (Before CI test pass, please copy & paste the result of "mvn test")
   
   ### Documentation (Optional)
   
   - In case of new functionality, my PR adds documentation in the following wiki page:
   
   (Link the GitHub wiki you added)
   
   ### Commits
   
   - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Code Quality
   
   - My diff has been formatted using helix-style.xml 
   (helix-style-intellij.xml if IntelliJ IDE is used)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] lei-xia edited a comment on pull request #1436: Not to reuse data accessor in Helix customized state provider

Posted by GitBox <gi...@apache.org>.
lei-xia edited a comment on pull request #1436:
URL: https://github.com/apache/helix/pull/1436#issuecomment-704416624


   There are two logic changes here, I know both of them are short, but can we break it down to two PRs? 1) Catch the exception and return false in GroupCommit, 2) Do not cache dataAccessor in CustomizedStateProvider.  Those two changes are independent of each other.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] mgao0 commented on pull request #1436: Not to reuse data accessor in Helix customized state provider

Posted by GitBox <gi...@apache.org>.
mgao0 commented on pull request #1436:
URL: https://github.com/apache/helix/pull/1436#issuecomment-703899196


   Code looks good to me. Could you please some more details in the PR description explaining why we want to make this change? Such as when Helix manager connects, it will create new client, etc.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] zhangmeng916 commented on pull request #1436: Not to cache data accessor in Helix customized state provider

Posted by GitBox <gi...@apache.org>.
zhangmeng916 commented on pull request #1436:
URL: https://github.com/apache/helix/pull/1436#issuecomment-704611335


   This PR is ready to merge. Approved by @mgao0 
   Final commit message:
   Not to cache data accessor in Helix customized state provider.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] jiajunwang merged pull request #1436: Not to cache data accessor in Helix customized state provider

Posted by GitBox <gi...@apache.org>.
jiajunwang merged pull request #1436:
URL: https://github.com/apache/helix/pull/1436


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] lei-xia commented on pull request #1436: Not to reuse data accessor in Helix customized state provider

Posted by GitBox <gi...@apache.org>.
lei-xia commented on pull request #1436:
URL: https://github.com/apache/helix/pull/1436#issuecomment-704415393






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org