You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by subhash-koganti <gi...@git.apache.org> on 2017/10/06 06:24:28 UTC
[GitHub] incubator-netbeans pull request #66: [NETBEANS-54] Module Review editor.sett...
GitHub user subhash-koganti opened a pull request:
https://github.com/apache/incubator-netbeans/pull/66
[NETBEANS-54] Module Review editor.settings.lib - Added Apache License
- no external libraries
- checked Rat report and found 11 XML files that don't have any license info defined on them. Added the license text on to them .
- After adding the text , Recompiled the code and ran the rat report again and Made sure that these files are fixed in the rat report .
- skimmed through the module, did not notice any additional problems
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/subhash-koganti/incubator-netbeans master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-netbeans/pull/66.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #66
----
commit da72fc10aa35921db7529d23b45bf9bb62d8f371
Author: subhash-koganti <su...@gmail.com>
Date: 2017-10-06T05:10:50Z
[NETBEANS-54] Module Review editor.settings.lib - Added Apache License
----
---
[GitHub] incubator-netbeans issue #66: [NETBEANS-54] Module Review editor.settings.li...
Posted by junichi11 <gi...@git.apache.org>.
Github user junichi11 commented on the issue:
https://github.com/apache/incubator-netbeans/pull/66
Probably, There is no document about it in the wiki. I think there is no problem even if a new branch is not created. But you may get a problem in your repository after your PR is merged. e.g. If your commits are rebased then merged in the upstream repository, the upstream repository has the different commit id from your one. To keep the master branch up-to-date with the upstream repository, I recommend that you use it :)
---
[GitHub] incubator-netbeans issue #66: [NETBEANS-54] Module Review editor.settings.li...
Posted by junichi11 <gi...@git.apache.org>.
Github user junichi11 commented on the issue:
https://github.com/apache/incubator-netbeans/pull/66
Thanks for fixing it.
BTW, You should create a new branch, then commit your changes. maybe, since next time?
---
[GitHub] incubator-netbeans pull request #66: [NETBEANS-54] Module Review editor.sett...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-netbeans/pull/66
---
[GitHub] incubator-netbeans issue #66: [NETBEANS-54] Module Review editor.settings.li...
Posted by subhash-koganti <gi...@git.apache.org>.
Github user subhash-koganti commented on the issue:
https://github.com/apache/incubator-netbeans/pull/66
sure sounds good.I am new to the group. Not sure what the process was. I was told to do a fork . But if Branching is the process , I will branch it next time. By the way is there a document where this is specified ?
---