You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by Filippo Diotalevi <fi...@gmail.com> on 2009/04/16 16:35:56 UTC

Re: [jira] Commented: (FELIX-1036) FileInstaller spawns multiple watchers for same directory

On Thu, Apr 16, 2009 at 4:12 PM, Sahoo (JIRA) <ji...@apache.org> wrote:
> Filippo,
>
> I tried the patch. It works as I see only one watcher per every watched directory, but for some reason, I see configuration values getting printed twice for the second directory as shown below:
>
> felix.fileinstall.poll  (ms)   5000
> felix.fileinstall.dir            /space/ss141213/WS/gf/v3.trunk.new/publish/glassfish/modules
> felix.fileinstall.debug          1
> felix.fileinstall.bundles.new.start          false
> felix.fileinstall.poll  (ms)   5000
> felix.fileinstall.dir            /space/ss141213/WS/gf/v3.trunk.new/publish/glassfish/domains/domain1/autodeploy-modules
> felix.fileinstall.debug          1
> felix.fileinstall.bundles.new.start          true
> Updating configuration from org.apache.felix.fileinstall-autodeploy-modules.cfg
> felix.fileinstall.poll  (ms)   5000
> felix.fileinstall.dir            /space/ss141213/WS/gf/v3.trunk.new/publish/glassfish/domains/domain1/autodeploy-modules
> felix.fileinstall.debug          1
> felix.fileinstall.bundles.new.start          true
>

I think that it is correct.

The first log is a fileinstall created with config.properties, I guess.

The second log is caused by cached configuration dictionary.

The third log is caused by fileinstall finding a configuration file.
It correctly determines that it's a configuration already existent (in
fact you see the new log "Updating configuration"; so it retrieves the
old configuration and .update() it.


-- 
Filippo Diotalevi

Re: [jira] Commented: (FELIX-1036) FileInstaller spawns multiple watchers for same directory

Posted by Sahoo <Sa...@Sun.COM>.
Filippo Diotalevi wrote:
> On Thu, Apr 16, 2009 at 4:12 PM, Sahoo (JIRA) <ji...@apache.org> wrote:
>   
>> Filippo,
>>
>> I tried the patch. It works as I see only one watcher per every watched directory, but for some reason, I see configuration values getting printed twice for the second directory as shown below:
>>
>> felix.fileinstall.poll  (ms)   5000
>> felix.fileinstall.dir            /space/ss141213/WS/gf/v3.trunk.new/publish/glassfish/modules
>> felix.fileinstall.debug          1
>> felix.fileinstall.bundles.new.start          false
>> felix.fileinstall.poll  (ms)   5000
>> felix.fileinstall.dir            /space/ss141213/WS/gf/v3.trunk.new/publish/glassfish/domains/domain1/autodeploy-modules
>> felix.fileinstall.debug          1
>> felix.fileinstall.bundles.new.start          true
>> Updating configuration from org.apache.felix.fileinstall-autodeploy-modules.cfg
>> felix.fileinstall.poll  (ms)   5000
>> felix.fileinstall.dir            /space/ss141213/WS/gf/v3.trunk.new/publish/glassfish/domains/domain1/autodeploy-modules
>> felix.fileinstall.debug          1
>> felix.fileinstall.bundles.new.start          true
>>
>>     
>
> I think that it is correct.
>
> The first log is a fileinstall created with config.properties, I guess.
>
> The second log is caused by cached configuration dictionary.
>
> The third log is caused by fileinstall finding a configuration file.
> It correctly determines that it's a configuration already existent (in
> fact you see the new log "Updating configuration"; so it retrieves the
> old configuration and .update() it.
>
>
>   
Looks like I missed the line "Updating configuration from 
org.apache.felix.fileinstall-autodeploy-modules.cfg." I will update the 
bug. The patch works for me.

Thanks,
Sahoo