You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2012/06/30 10:15:42 UTC
svn commit: r1355660 -
/ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilHttp.java
Author: jleroux
Date: Sat Jun 30 08:15:42 2012
New Revision: 1355660
URL: http://svn.apache.org/viewvc?rev=1355660&view=rev
Log:
"Login out on a cluster handled by DeltaManager causes a NPE" https://issues.apache.org/jira/browse/OFBIZ-4289
Uses a HashMap instead of a FastMap here because else we get this kind of error when OFBiz is shut down:
2012-06-12 10:35:29,921 (OFBiz_Shutdown_Hook) [ StandardSession.java:1567:WARN ] Cannot serialize session attribute LAST_VIEW_PARAMS for session 00C48D0D76821C98403482FAE8B77C24.jvm1
java.io.NotSerializableException: net.sf.json.JSONObject
at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1164)
at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:330)
at javolution.util.FastMap.writeObject(FastMap.java:1513)
Modified:
ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilHttp.java
Modified: ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilHttp.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilHttp.java?rev=1355660&r1=1355659&r2=1355660&view=diff
==============================================================================
--- ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilHttp.java (original)
+++ ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilHttp.java Sat Jun 30 08:15:42 2012
@@ -113,7 +113,7 @@ public class UtilHttp {
*/
public static Map<String, Object> getParameterMap(HttpServletRequest request, Set<? extends String> nameSet, Boolean onlyIncludeOrSkip) {
boolean onlyIncludeOrSkipPrim = onlyIncludeOrSkip == null ? true : onlyIncludeOrSkip.booleanValue();
- Map<String, Object> paramMap = FastMap.newInstance();
+ Map<String, Object> paramMap = new HashMap<String, Object>();
// add all the actual HTTP request parameters
Enumeration<String> e = UtilGenerics.cast(request.getParameterNames());
Re: svn commit: r1355660 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilHttp.java
Posted by Jacques Le Roux <ja...@les7arts.com>.
Hi Jacopo,
At r1355676, after an ant clean-all load-demo
I get this with tools\startofbizpos
2012-06-30 11:45:11,718 (main) [ ComponentContainer.java:180:INFO ] Auto-Loading component directory :
[D:/workspace/ofbizClean/hot-deploy]
2012-06-30 11:45:11,734 (main) [ ComponentContainer.java:149:INFO ] All components loaded
2012-06-30 11:45:11,734 (main) [ ContainerLoader.java:96 :INFO ] Loading container: classloader-container
2012-06-30 11:45:11,937 (main) [ClassLoaderContainer.java:50 :INFO ] CachedClassLoader created
2012-06-30 11:45:11,953 (main) [ ContainerLoader.java:145:INFO ] Loading component's container: jpos.device-container
2012-06-30 11:45:11,953 (main) [ ContainerLoader.java:145:INFO ] Loading component's container: pos-container
2012-06-30 11:45:11,968 (main) [ ContainerLoader.java:253:INFO ] [Startup] Starting containers...
org.ofbiz.base.start.StartupException: Cannot start() org.ofbiz.pos.container.JposDeviceContainer (No container found with the name
: null)
at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:262)
at org.ofbiz.base.start.Start.startStartLoaders(Start.java:362)
at org.ofbiz.base.start.Start.start(Start.java:337)
at org.ofbiz.base.start.Start.main(Start.java:139)
I had a quick look but do not have enough the time to look at it this morning. It could be due to a local setting, because if I
comment out the jpos.device-container in pos ofbiz-component.xml all work well.
I did a fast review of your changes and they look good to me, I really appreciate the idea and the effort, it's really heading
in the right direction!
Jacques
From: "Jacopo Cappellato" <ja...@hotwaxmedia.com>
> As I mentioned in Jira, I am not against this change (i.e. switch from FastMap to Hashmap) but I doubt this is related to the
> issue you were experiencing.
>
> Jacopo
>
> On Jun 30, 2012, at 10:15 AM, jleroux@apache.org wrote:
>
>> Author: jleroux
>> Date: Sat Jun 30 08:15:42 2012
>> New Revision: 1355660
>>
>> URL: http://svn.apache.org/viewvc?rev=1355660&view=rev
>> Log:
>> "Login out on a cluster handled by DeltaManager causes a NPE" https://issues.apache.org/jira/browse/OFBIZ-4289
>>
>> Uses a HashMap instead of a FastMap here because else we get this kind of error when OFBiz is shut down:
>>
>> 2012-06-12 10:35:29,921 (OFBiz_Shutdown_Hook) [ StandardSession.java:1567:WARN ] Cannot serialize session attribute
>> LAST_VIEW_PARAMS for session 00C48D0D76821C98403482FAE8B77C24.jvm1
>> java.io.NotSerializableException: net.sf.json.JSONObject
>> at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1164)
>> at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:330)
>> at javolution.util.FastMap.writeObject(FastMap.java:1513)
>>
>> Modified:
>> ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilHttp.java
>>
>> Modified: ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilHttp.java
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilHttp.java?rev=1355660&r1=1355659&r2=1355660&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilHttp.java (original)
>> +++ ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilHttp.java Sat Jun 30 08:15:42 2012
>> @@ -113,7 +113,7 @@ public class UtilHttp {
>> */
>> public static Map<String, Object> getParameterMap(HttpServletRequest request, Set<? extends String> nameSet, Boolean
>> onlyIncludeOrSkip) {
>> boolean onlyIncludeOrSkipPrim = onlyIncludeOrSkip == null ? true : onlyIncludeOrSkip.booleanValue();
>> - Map<String, Object> paramMap = FastMap.newInstance();
>> + Map<String, Object> paramMap = new HashMap<String, Object>();
>>
>> // add all the actual HTTP request parameters
>> Enumeration<String> e = UtilGenerics.cast(request.getParameterNames());
>>
>>
>
>
Re: svn commit: r1355660 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilHttp.java
Posted by Jacopo Cappellato <ja...@hotwaxmedia.com>.
As I mentioned in Jira, I am not against this change (i.e. switch from FastMap to Hashmap) but I doubt this is related to the issue you were experiencing.
Jacopo
On Jun 30, 2012, at 10:15 AM, jleroux@apache.org wrote:
> Author: jleroux
> Date: Sat Jun 30 08:15:42 2012
> New Revision: 1355660
>
> URL: http://svn.apache.org/viewvc?rev=1355660&view=rev
> Log:
> "Login out on a cluster handled by DeltaManager causes a NPE" https://issues.apache.org/jira/browse/OFBIZ-4289
>
> Uses a HashMap instead of a FastMap here because else we get this kind of error when OFBiz is shut down:
>
> 2012-06-12 10:35:29,921 (OFBiz_Shutdown_Hook) [ StandardSession.java:1567:WARN ] Cannot serialize session attribute LAST_VIEW_PARAMS for session 00C48D0D76821C98403482FAE8B77C24.jvm1
> java.io.NotSerializableException: net.sf.json.JSONObject
> at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1164)
> at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:330)
> at javolution.util.FastMap.writeObject(FastMap.java:1513)
>
> Modified:
> ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilHttp.java
>
> Modified: ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilHttp.java
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilHttp.java?rev=1355660&r1=1355659&r2=1355660&view=diff
> ==============================================================================
> --- ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilHttp.java (original)
> +++ ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilHttp.java Sat Jun 30 08:15:42 2012
> @@ -113,7 +113,7 @@ public class UtilHttp {
> */
> public static Map<String, Object> getParameterMap(HttpServletRequest request, Set<? extends String> nameSet, Boolean onlyIncludeOrSkip) {
> boolean onlyIncludeOrSkipPrim = onlyIncludeOrSkip == null ? true : onlyIncludeOrSkip.booleanValue();
> - Map<String, Object> paramMap = FastMap.newInstance();
> + Map<String, Object> paramMap = new HashMap<String, Object>();
>
> // add all the actual HTTP request parameters
> Enumeration<String> e = UtilGenerics.cast(request.getParameterNames());
>
>