[GitHub] [libcloud] micafer commented on a change in pull request #1504: Add support for Linode's API v4

[GitBox <gi...@apache.org>]

micafer commented on a change in pull request #1504:
URL: https://github.com/apache/libcloud/pull/1504#discussion_r522843919



##########
File path: libcloud/compute/drivers/linode.py
##########
@@ -728,6 +752,912 @@ def _to_nodes(self, objs):
         return list(nodes.values())
 
 
+class LinodeNodeDriverV4(LinodeNodeDriver):
+
+    connectionCls = LinodeConnectionV4
+    _linode_disk_filesystems = LINODE_DISK_FILESYSTEMS_V4
+
+    LINODE_STATES = {
+        'running': NodeState.RUNNING,
+        'stopped': NodeState.STOPPED,
+        'provisioning': NodeState.STARTING,
+        'offline': NodeState.STOPPED,
+        'booting': NodeState.STARTING,
+        'rebooting': NodeState.REBOOTING,
+        'shutting_down': NodeState.STOPPING,
+        'deleting': NodeState.PENDING,
+        'migrating': NodeState.MIGRATING,
+        'rebuilding': NodeState.UPDATING,
+        'cloning': NodeState.MIGRATING,
+        'restoring': NodeState.PENDING,

Review comment:
       There is a missing state 'resizing'. I checked the API documentation and it does not appear. But I made some tests and it does exist. May be a good map value could be:
   'resizing': NodeState.RECONFIGURING
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org