[jira] [Assigned] (MESOS-9114) cmake build is broken on macos

["Benjamin Mahler (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/MESOS-9114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Mahler reassigned MESOS-9114:
--------------------------------------

    Assignee: Chun-Hung Hsiao

> cmake build is broken on macos
> ------------------------------
>
>                 Key: MESOS-9114
>                 URL: https://issues.apache.org/jira/browse/MESOS-9114
>             Project: Mesos
>          Issue Type: Bug
>    Affects Versions: 1.7.0
>         Environment: Currently broken e.g., macos-10.13.6, and passes on fedora-23.
>            Reporter: Benjamin Bannier
>            Assignee: Chun-Hung Hsiao
>            Priority: Major
>
> Since the changes for MESOS-9092 have landed it seems impossible to perform a cmake-based build on macos. This seems independent of the used generator and both {{make}} and {{ninja}}-based builds appear broken, e.g.,
> {noformat}
> # cmake ~/src/mesos
> # make stout-tests
> ...
>  87%] Building CXX object 3rdparty/stout/tests/CMakeFiles/stout-tests.dir/uuid_tests.cpp.o
> In file included from /Users/bbannier/src/mesos/3rdparty/stout/tests/json_tests.cpp:24:
> In file included from /Users/bbannier/src/mesos/3rdparty/stout/include/stout/json.hpp:41:
> /Users/bbannier/src/mesos/3rdparty/stout/include/stout/jsonify.hpp:36:10: fatal error: 'rapidjson/stringbuffer.h' file not found
> #include <rapidjson/stringbuffer.h>
>          ^~~~~~~~~~~~~~~~~~~~~~~~~~
> ...
> {noformat}
> As a workaround I can apply the following patch,
> {code}
> diff --git a/3rdparty/CMakeLists.txt b/3rdparty/CMakeLists.txt
> index 9b0dfe0ab..b244267e8 100644
> --- a/3rdparty/CMakeLists.txt
> +++ b/3rdparty/CMakeLists.txt
> @@ -440,9 +440,7 @@ EXTERNAL(rapidjson ${RAPIDJSON_VERSION} ${CMAKE_CURRENT_BINARY_DIR})
>  add_library(rapidjson INTERFACE)
>  add_dependencies(rapidjson ${RAPIDJSON_TARGET})
> -target_include_directories(
> -    rapidjson INTERFACE
> -    ${RAPIDJSON_ROOT}/rapidjson-${RAPIDJSON_VERSION}/include)
> +target_include_directories(rapidjson INTERFACE ${RAPIDJSON_ROOT}/include)
>  ExternalProject_Add(
>    ${RAPIDJSON_TARGET}
> {code}
> This however seems to break cmake-based builds on Linux.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)