[GitHub] mistercrunch opened a new pull request #6294: Wrap with

[GitBox <gi...@apache.org>]

mistercrunch opened a new pull request #6294: Wrap <LoadableRenderer /> with <ErrorBoundary />
URL: https://github.com/apache/incubator-superset/pull/6294
 
 
   It appears that since the introduction of <SuperChart />, errors in the
   visualization javascript (which are somewhat common and expected,
   especially as we'll support plugins) were not handled and the whole
   page would throw and go missing.
   
   Here I'm introducing a new <ErrorBoundary /> component that elegantly
   wraps other
   components and handles errors. It's inspired by:
   https://reactjs.org/docs/error-boundaries.html
   
   The default behavior of the component is to simply surface the error
   as an <Alert bsStyle="danger" /> and exposes the React stacktrace
   when clicking on the error.
   
   It's also possible to use component and pass an onError handler and not
   show the default message.
   
   This also fixes some minor bugs in TimeTable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org