[jira] [Commented] (HBASE-11354) HConnectionImplementation#DelayedClosing does not start

["Lars Hofhansl (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-11354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15544548#comment-15544548 ] 

Lars Hofhansl commented on HBASE-11354:
---------------------------------------

Looks like this is now preventing the region server (0.98) from stopping cleanly.
The only non-daemon thread:
{code}
"ZooKeeperWatcher and Master delayed closing for connection hconnection-0x2454e7
31" #119 prio=5 os_prio=0 tid=0x00007f2e25d00800 nid=0x2e27 in Object.wait() [0x
00007f2dece35000]
   java.lang.Thread.State: TIMED_WAITING (on object monitor)
        at java.lang.Object.wait(Native Method)
        at org.apache.hadoop.hbase.util.Sleeper.sleep(Sleeper.java:92)
        - locked <0x00000005b58f8b90> (a java.lang.Object)
        at org.apache.hadoop.hbase.Chore.run(Chore.java:88)
        at java.lang.Thread.run(Thread.java:745)
{code}

[~apurtell], [~vincentpoon]

> HConnectionImplementation#DelayedClosing does not start
> -------------------------------------------------------
>
>                 Key: HBASE-11354
>                 URL: https://issues.apache.org/jira/browse/HBASE-11354
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 0.99.0, 0.98.3
>            Reporter: Qianxi Zhang
>            Assignee: Qianxi Zhang
>            Priority: Minor
>             Fix For: 0.98.23
>
>         Attachments: HBASE-11354-0.98.patch, HBASE_11354 (1).patch, HBASE_11354.patch, HBASE_11354.patch, HBASE_11354.patch
>
>
> The method "createAndStart" in class DelayedClosing only creates a instance, but forgets to start it. So thread delayedClosing is not running all the time.
> ConnectionManager#1623
> {code}
>       static DelayedClosing createAndStart(HConnectionImplementation hci){
>         Stoppable stoppable = new Stoppable() {
>               private volatile boolean isStopped = false;
>               @Override public void stop(String why) { isStopped = true;}
>               @Override public boolean isStopped() {return isStopped;}
>             };
>         return new DelayedClosing(hci, stoppable);
>       }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)