You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "James Nord (JIRA)" <ji...@codehaus.org> on 2008/06/11 17:27:13 UTC
[jira] Created: (MSITE-336) site url inheritance broken for UNC
paths
site url inheritance broken for UNC paths
-----------------------------------------
Key: MSITE-336
URL: http://jira.codehaus.org/browse/MSITE-336
Project: Maven 2.x Site Plugin
Issue Type: Bug
Components: site:deploy
Affects Versions: 2.0-beta-6
Environment: Win XP SP2
Reporter: James Nord
Attachments: build.txt
I have a parent POM that is inherited by multiple projects that specifies site wide default settings.
(e.g)
Parent\pom.xml <--- this is the pom containing the site configuration
Parent\CheckStyleConfig\pom.xml
Part of this is the site deploy
<distributionManagement>
<site>
<id>nds-uk.site</id>
<url>file://///scg-nas.uk.nds.com/maven_sites/${project.groupId}/${project.artifactId}/${project.version}</url>
</site>
</distributionManagement>
running site:deploy on the sub procject results in it using a corrupted version of the url.
build output attached.
Notice the corruption of the original parent file:///// (2 slashes are removed so it tries to deploy to local HDD)
parent (OK 5 slashes) file://///scg-nas.uk.nds.com/maven_sites/com.nds.cab.scg/common-parent/1.0.0.0-SNAPSHOT - Session: Opened
child (bad 3 slashes) file:///scg-nas.uk.nds.com/maven_sites/com.nds.cab.scg/common-checkstyle/1.0.0.0-SNAPSHOT/common-checkstyle - Session: Opened
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MNG-3621) site url inheritance broken for UNC paths
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brett Porter closed MNG-3621.
-----------------------------
Resolution: Fixed
Fix Version/s: 2.1.0
> site url inheritance broken for UNC paths
> -----------------------------------------
>
> Key: MNG-3621
> URL: http://jira.codehaus.org/browse/MNG-3621
> Project: Maven 2
> Issue Type: Bug
> Components: Inheritance and Interpolation
> Affects Versions: 2.0.9
> Environment: Win XP SP2
> Reporter: James Nord
> Assignee: Brett Porter
> Fix For: 2.0.11, 2.1.0
>
> Attachments: build.txt, MNG-3621.patch
>
>
> I have a parent POM that is inherited by multiple projects that specifies site wide default settings.
> (e.g)
> Parent\pom.xml <--- this is the pom containing the site configuration
> Parent\CheckStyleConfig\pom.xml
> Part of this is the site deploy
> <distributionManagement>
> <site>
> <id>nds-uk.site</id>
> <url>file://///scg-nas.uk.nds.com/maven_sites/${project.groupId}/${project.artifactId}/${project.version}</url>
> </site>
> </distributionManagement>
> running site:deploy on the sub procject results in it using a corrupted version of the url.
> build output attached.
> Notice the corruption of the original parent file:///// (2 slashes are removed so it tries to deploy to local HDD)
> parent (OK 5 slashes) file://///scg-nas.uk.nds.com/maven_sites/com.nds.cab.scg/common-parent/1.0.0.0-SNAPSHOT - Session: Opened
> child (bad 3 slashes) file:///scg-nas.uk.nds.com/maven_sites/com.nds.cab.scg/common-checkstyle/1.0.0.0-SNAPSHOT/common-checkstyle - Session: Opened
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3621) site url inheritance broken for UNC
paths
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Bentmann updated MNG-3621:
-----------------------------------
Testcase included: yes
Patch Submitted: [Yes]
> site url inheritance broken for UNC paths
> -----------------------------------------
>
> Key: MNG-3621
> URL: http://jira.codehaus.org/browse/MNG-3621
> Project: Maven 2
> Issue Type: Bug
> Components: Inheritance and Interpolation
> Affects Versions: 2.0.9
> Environment: Win XP SP2
> Reporter: James Nord
> Attachments: build.txt, MNG-3621.patch
>
>
> I have a parent POM that is inherited by multiple projects that specifies site wide default settings.
> (e.g)
> Parent\pom.xml <--- this is the pom containing the site configuration
> Parent\CheckStyleConfig\pom.xml
> Part of this is the site deploy
> <distributionManagement>
> <site>
> <id>nds-uk.site</id>
> <url>file://///scg-nas.uk.nds.com/maven_sites/${project.groupId}/${project.artifactId}/${project.version}</url>
> </site>
> </distributionManagement>
> running site:deploy on the sub procject results in it using a corrupted version of the url.
> build output attached.
> Notice the corruption of the original parent file:///// (2 slashes are removed so it tries to deploy to local HDD)
> parent (OK 5 slashes) file://///scg-nas.uk.nds.com/maven_sites/com.nds.cab.scg/common-parent/1.0.0.0-SNAPSHOT - Session: Opened
> child (bad 3 slashes) file:///scg-nas.uk.nds.com/maven_sites/com.nds.cab.scg/common-checkstyle/1.0.0.0-SNAPSHOT/common-checkstyle - Session: Opened
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3621) site url inheritance broken for UNC
paths
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Bentmann updated MNG-3621:
-----------------------------------
Attachment: MNG-3621.patch
Proposed patch which simply retains a leading double slash. As the unit test shows, this makes UNC paths as constructed by Java (btw, these have only 4 successive slashes on a Sun JRE 1.6.0_04, not 5 as used by the reporter) successfully pass {{DefaultModelInheritanceAssembler.appendPath()}}.
> site url inheritance broken for UNC paths
> -----------------------------------------
>
> Key: MNG-3621
> URL: http://jira.codehaus.org/browse/MNG-3621
> Project: Maven 2
> Issue Type: Bug
> Components: Inheritance and Interpolation
> Affects Versions: 2.0.9
> Environment: Win XP SP2
> Reporter: James Nord
> Attachments: build.txt, MNG-3621.patch
>
>
> I have a parent POM that is inherited by multiple projects that specifies site wide default settings.
> (e.g)
> Parent\pom.xml <--- this is the pom containing the site configuration
> Parent\CheckStyleConfig\pom.xml
> Part of this is the site deploy
> <distributionManagement>
> <site>
> <id>nds-uk.site</id>
> <url>file://///scg-nas.uk.nds.com/maven_sites/${project.groupId}/${project.artifactId}/${project.version}</url>
> </site>
> </distributionManagement>
> running site:deploy on the sub procject results in it using a corrupted version of the url.
> build output attached.
> Notice the corruption of the original parent file:///// (2 slashes are removed so it tries to deploy to local HDD)
> parent (OK 5 slashes) file://///scg-nas.uk.nds.com/maven_sites/com.nds.cab.scg/common-parent/1.0.0.0-SNAPSHOT - Session: Opened
> child (bad 3 slashes) file:///scg-nas.uk.nds.com/maven_sites/com.nds.cab.scg/common-checkstyle/1.0.0.0-SNAPSHOT/common-checkstyle - Session: Opened
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3621) site url inheritance broken for UNC
paths
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brett Porter updated MNG-3621:
------------------------------
Fix Version/s: 2.0.10
> site url inheritance broken for UNC paths
> -----------------------------------------
>
> Key: MNG-3621
> URL: http://jira.codehaus.org/browse/MNG-3621
> Project: Maven 2
> Issue Type: Bug
> Components: Inheritance and Interpolation
> Affects Versions: 2.0.9
> Environment: Win XP SP2
> Reporter: James Nord
> Fix For: 2.0.10
>
> Attachments: build.txt, MNG-3621.patch
>
>
> I have a parent POM that is inherited by multiple projects that specifies site wide default settings.
> (e.g)
> Parent\pom.xml <--- this is the pom containing the site configuration
> Parent\CheckStyleConfig\pom.xml
> Part of this is the site deploy
> <distributionManagement>
> <site>
> <id>nds-uk.site</id>
> <url>file://///scg-nas.uk.nds.com/maven_sites/${project.groupId}/${project.artifactId}/${project.version}</url>
> </site>
> </distributionManagement>
> running site:deploy on the sub procject results in it using a corrupted version of the url.
> build output attached.
> Notice the corruption of the original parent file:///// (2 slashes are removed so it tries to deploy to local HDD)
> parent (OK 5 slashes) file://///scg-nas.uk.nds.com/maven_sites/com.nds.cab.scg/common-parent/1.0.0.0-SNAPSHOT - Session: Opened
> child (bad 3 slashes) file:///scg-nas.uk.nds.com/maven_sites/com.nds.cab.scg/common-checkstyle/1.0.0.0-SNAPSHOT/common-checkstyle - Session: Opened
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Moved: (MNG-3621) site url inheritance broken for UNC paths
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Bentmann moved MSITE-336 to MNG-3621:
----------------------------------------------
Affects Version/s: (was: 2.0-beta-6)
2.0.9
Component/s: (was: site:deploy)
Inheritance and Interpolation
Complexity: Novice
Key: MNG-3621 (was: MSITE-336)
Project: Maven 2 (was: Maven 2.x Site Plugin)
> site url inheritance broken for UNC paths
> -----------------------------------------
>
> Key: MNG-3621
> URL: http://jira.codehaus.org/browse/MNG-3621
> Project: Maven 2
> Issue Type: Bug
> Components: Inheritance and Interpolation
> Affects Versions: 2.0.9
> Environment: Win XP SP2
> Reporter: James Nord
> Attachments: build.txt
>
>
> I have a parent POM that is inherited by multiple projects that specifies site wide default settings.
> (e.g)
> Parent\pom.xml <--- this is the pom containing the site configuration
> Parent\CheckStyleConfig\pom.xml
> Part of this is the site deploy
> <distributionManagement>
> <site>
> <id>nds-uk.site</id>
> <url>file://///scg-nas.uk.nds.com/maven_sites/${project.groupId}/${project.artifactId}/${project.version}</url>
> </site>
> </distributionManagement>
> running site:deploy on the sub procject results in it using a corrupted version of the url.
> build output attached.
> Notice the corruption of the original parent file:///// (2 slashes are removed so it tries to deploy to local HDD)
> parent (OK 5 slashes) file://///scg-nas.uk.nds.com/maven_sites/com.nds.cab.scg/common-parent/1.0.0.0-SNAPSHOT - Session: Opened
> child (bad 3 slashes) file:///scg-nas.uk.nds.com/maven_sites/com.nds.cab.scg/common-checkstyle/1.0.0.0-SNAPSHOT/common-checkstyle - Session: Opened
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-3621) site url inheritance broken for UNC
paths
Posted by "Paul Nyheim (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=162510#action_162510 ]
Paul Nyheim commented on MNG-3621:
----------------------------------
I would just like to add an observation to this issue.
In our setup, we have extracted the url to a property in the pom
{code:xml}
<properties>
<distMgtSiteUrl>file:////my.server.com/share</distMgtSiteUrl>
</properties>
{code}
and in that case, no path manipulation is done in {{DefaultModelInheritanceAssembler.appendPath()}}. as the path passed to it will be the non-interpolated property: {{${distMgtSiteUrl}}}.
> site url inheritance broken for UNC paths
> -----------------------------------------
>
> Key: MNG-3621
> URL: http://jira.codehaus.org/browse/MNG-3621
> Project: Maven 2
> Issue Type: Bug
> Components: Inheritance and Interpolation
> Affects Versions: 2.0.9
> Environment: Win XP SP2
> Reporter: James Nord
> Fix For: 2.0.11
>
> Attachments: build.txt, MNG-3621.patch
>
>
> I have a parent POM that is inherited by multiple projects that specifies site wide default settings.
> (e.g)
> Parent\pom.xml <--- this is the pom containing the site configuration
> Parent\CheckStyleConfig\pom.xml
> Part of this is the site deploy
> <distributionManagement>
> <site>
> <id>nds-uk.site</id>
> <url>file://///scg-nas.uk.nds.com/maven_sites/${project.groupId}/${project.artifactId}/${project.version}</url>
> </site>
> </distributionManagement>
> running site:deploy on the sub procject results in it using a corrupted version of the url.
> build output attached.
> Notice the corruption of the original parent file:///// (2 slashes are removed so it tries to deploy to local HDD)
> parent (OK 5 slashes) file://///scg-nas.uk.nds.com/maven_sites/com.nds.cab.scg/common-parent/1.0.0.0-SNAPSHOT - Session: Opened
> child (bad 3 slashes) file:///scg-nas.uk.nds.com/maven_sites/com.nds.cab.scg/common-checkstyle/1.0.0.0-SNAPSHOT/common-checkstyle - Session: Opened
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira