You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/09/13 14:42:36 UTC

[GitHub] [incubator-echarts] pissang opened a new pull request #13271: [5.0] [Feature] Bring shape morphing ability in custom series

pissang opened a new pull request #13271:
URL: https://github.com/apache/incubator-echarts/pull/13271


   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [ ] bug fixing
   - [x] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   In the previous custom series. We can't do animation across different types of shapes. For example, we can't animate from a sector to a rectangle. In this PR, we bring the ability to do smooth shape morphing across different shapes.
   
   An example of the transition between `map`, `bar`, `bubble` and `pie`(These are all implemented by custom series.)
   ![Screen Recording 2020-09-13 at 10 27 04 PM](https://user-images.githubusercontent.com/841551/93020799-df552e80-f611-11ea-9d3b-1d28912b3dc5.gif)
   
   
   
   ## Usage
   
   ### Are there any API changes?
   
   We add a boolean property called `shapeMorphing` in the returned element option in `renderItem`. With it enabled, the shape will be morphed from the previous shape smoothly when the type is changed.
   
   For example:
   ```js
   // Render as rectangle at first time.
   renderItem(params, api) {
     return {
        type: 'rect'
        ....
      }
   }
   // Change to a circle.
   renderItem(params, api) {
     return {
        type: 'circle',
        // Enable morphing from the previous rectangle.
        shapeMorphing: true
        ....
      }
   }
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13271: [5.0] [Feature] Bring shape morphing ability in custom series

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13271:
URL: https://github.com/apache/incubator-echarts/pull/13271#issuecomment-691680165


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
   
   The pull request is marked to be `PR: author is committer` because you are a committer of this project.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13271: [5.0] [Feature] Bring shape morphing ability in custom series

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13271:
URL: https://github.com/apache/incubator-echarts/pull/13271#issuecomment-692565212


   Congratulations! Your PR has been merged. Thanks for your contribution! 👍


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] 100pah merged pull request #13271: [5.0] [Feature] Bring shape morphing ability in custom series

Posted by GitBox <gi...@apache.org>.
100pah merged pull request #13271:
URL: https://github.com/apache/incubator-echarts/pull/13271


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org