You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Mona Chitnis <mo...@yahoo.in> on 2014/03/14 21:32:18 UTC

Re: Review Request 18257: [OOZIE-1703] User should be able to set bundle/coord end-time before start time

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18257/#review37269
-----------------------------------------------------------


The unit test does not test for bundle status being updated to SUSPENDED. Also it is not testing the case where start time is after end time

- Mona Chitnis


On Feb. 21, 2014, 10:26 p.m., Purshotam Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18257/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2014, 10:26 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1703
>     https://issues.apache.org/jira/browse/OOZIE-1703
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> This is one of the important use-case in case of versioning.
> 
> User can set end date of old coord/bundle before start date( if coord/bundle is supposed to run in future), so that it doesn't run and user can safely upload new version.
> 
> 
> We should also lookahead at created actions that become invalid because of the new end time.
> These actions should be deleted from DB.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java cd2c844 
>   core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 4957330 
>   core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java b9bbf16 
>   docs/src/site/twiki/DG_CommandLineTool.twiki 0748ff8 
> 
> Diff: https://reviews.apache.org/r/18257/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Purshotam Shah
> 
>