[GitHub] [cassandra-dtest] adelapena commented on a diff in pull request #185: Fix test expectations for CASSANDRA-17034

[GitBox <gi...@apache.org>]

adelapena commented on code in PR #185:
URL: https://github.com/apache/cassandra-dtest/pull/185#discussion_r855315220


##########
snapshot_test.py:
##########
@@ -270,7 +270,14 @@ def test_archive_commitlog_point_in_time_with_active_commitlog_ln(self):
         """
         self.run_archive_commitlog(restore_point_in_time=True, archive_active_commitlogs=True, archive_command='ln')
 
-    def run_archive_commitlog(self, restore_point_in_time=False, restore_archived_commitlog=True, archive_active_commitlogs=False, archive_command='cp'):
+    @since('4.1')
+    def test_archive_commitlog_restore_skip_by_position(self):
+        """
+        Test archive commit log not restored because of specified snapshot commit log position
+        """
+        self.run_archive_commitlog(restore_point_in_time=True, archive_active_commitlogs=True, specify_commitlog_position=True, archive_command='ln')
+
+    def run_archive_commitlog(self, restore_point_in_time=False, restore_archived_commitlog=True, archive_active_commitlogs=False, specify_commitlog_position=False, archive_command='cp'):

Review Comment:
   Nit: can we split this line to not exceed 120 chars? By the way, it's not related to the patch so we don't have to address it here, but it seems that `archive_active_commitlogs` is not used since CASSANDRA-12509, and the tests `test_archive_commitlog_point_in_time` and `test_archive_commitlog_point_in_time_with_active_commitlog` do the same thing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org