[GitHub] [spark] hvanhovell commented on a diff in pull request #40265: [SPARK-42556][CONNECT] Dataset.colregex should link a plan_id when it only matches a single column.

["hvanhovell (via GitHub)" <gi...@apache.org>]

hvanhovell commented on code in PR #40265:
URL: https://github.com/apache/spark/pull/40265#discussion_r1124349655


##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/Dataset.scala:
##########
@@ -940,8 +940,17 @@ class Dataset[T] private[sql] (
    * @group untypedrel
    * @since 3.4.0
    */
-  def colRegex(colName: String): Column = Column { builder =>
-    builder.getUnresolvedRegexBuilder.setColName(colName)
+  def colRegex(colName: String): Column = {
+    val planId = if (plan.getRoot.hasCommon && plan.getRoot.getCommon.hasPlanId) {

Review Comment:
   Perhaps put this in a helper function?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org