You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2017/07/19 20:06:13 UTC

[kudu-CR] [WIP]log block manager:mark container as 'non-writable' after IOError

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/7374

to look at the new patch set (#6).

Change subject: [WIP]log block manager:mark container as 'non-writable' after IOError
......................................................................

[WIP]log block manager:mark container as 'non-writable' after
IOError

Currently, container in-memory accounting is updated only after
metadata get successfully synced. This may bring in inconsistent
state between data and metadata when metadata record is actually
been written to disk but fsync() does not succeed.

This patch marks container as 'non-writable' if there is IOError
during syncing data and metdata while closing a block, to avoid
further in-memory state inconsistency. It also adds test case
for fault injection around block closure to ensure consistent
container's in-memory accounting.

Change-Id: I15062b9d82c9cb563fb6bb2af7ec89da5f71e28f
---
A src/emptydata-logeio-fixed.patch
A src/emptydata-logeio-updated.patch
A src/emptydata-logeio.patch
A src/emptydata.patch
A src/fsynctestcase-2.patch
A src/fsynctestcase-fix-1.patch
A src/fsynctestcase-fix.patch
A src/fsynctestcase-updated.patch
A src/fsynctestcase.patch
A src/inject-failure.patch
A src/inject_failure.patch
A src/kudu-1.patch
A src/kudu-2.patch
A src/kudu-3.patch
A src/kudu-4.patch
A src/kudu-5.patch
A src/kudu-6.patch
A src/kudu-commitdelete.patch
A src/kudu.patch
M src/kudu/fs/block_manager-test.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/util/env_posix.cc
A src/logeio.patch
A src/read_only.patch
A src/test-without-fix.patch
25 files changed, 12,099 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/7374/6
-- 
To view, visit http://gerrit.cloudera.org:8080/7374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15062b9d82c9cb563fb6bb2af7ec89da5f71e28f
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot