You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/11/10 08:40:42 UTC

[GitHub] [flink] wangyang0918 opened a new pull request #14012: [FLINK-17857][test] Make K8s e2e tests could run on Mac

wangyang0918 opened a new pull request #14012:
URL: https://github.com/apache/flink/pull/14012


   Since the code in master has changes after #12451 is approved, I am afraid some K8s e2e tests still could not work on Mac OS. This PR will fix these tests and make them could run on Mac. Of cause, the PR will not affect the E2E tests on azure.
   
   I have run the following tests on Mac for more than five times for each. They could all pass.
   
   * `test_kubernetes_application.sh`
   * `test_kubernetes_embedded_job.sh`
   * `test_kubernetes_session.sh`
   * `test_kubernetes_itcases.sh`
   * `test_kubernetes_pyflink_application.sh`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wangyang0918 commented on pull request #14012: [FLINK-17857][test] Make K8s e2e tests could run on Mac

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #14012:
URL: https://github.com/apache/flink/pull/14012#issuecomment-837827708


   Rebase latest master since FLINK-22577 is merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14012: [FLINK-17857][test] Make K8s e2e tests could run on Mac

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14012:
URL: https://github.com/apache/flink/pull/14012#issuecomment-724568763


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5640ffc3f9d141cfcce5cf6a871378774aff803a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9392",
       "triggerID" : "5640ffc3f9d141cfcce5cf6a871378774aff803a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7ad6bfa8606b7d6d82b6edd12a720d2b6c3ce842",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17159",
       "triggerID" : "7ad6bfa8606b7d6d82b6edd12a720d2b6c3ce842",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ec6bda8748f9a4ab81fe59cb1e41beeb53df263e",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17698",
       "triggerID" : "ec6bda8748f9a4ab81fe59cb1e41beeb53df263e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ec6bda8748f9a4ab81fe59cb1e41beeb53df263e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17698) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14012: [FLINK-17857][test] Make K8s e2e tests could run on Mac

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14012:
URL: https://github.com/apache/flink/pull/14012#issuecomment-724568763


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5640ffc3f9d141cfcce5cf6a871378774aff803a",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9392",
       "triggerID" : "5640ffc3f9d141cfcce5cf6a871378774aff803a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7ad6bfa8606b7d6d82b6edd12a720d2b6c3ce842",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17159",
       "triggerID" : "7ad6bfa8606b7d6d82b6edd12a720d2b6c3ce842",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5640ffc3f9d141cfcce5cf6a871378774aff803a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9392) 
   * 7ad6bfa8606b7d6d82b6edd12a720d2b6c3ce842 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17159) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wangyang0918 commented on a change in pull request #14012: [FLINK-17857][test] Make K8s e2e tests could run on Mac

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #14012:
URL: https://github.com/apache/flink/pull/14012#discussion_r619764781



##########
File path: flink-end-to-end-tests/test-scripts/common_kubernetes.sh
##########
@@ -25,7 +25,7 @@ MINIKUBE_START_RETRIES=3
 MINIKUBE_START_BACKOFF=5
 RESULT_HASH="e682ec6622b5e83f2eb614617d5ab2cf"
 MINIKUBE_VERSION="v1.8.2"
-MINIKUBE_PATH="/usr/local/bin/minikube-$MINIKUBE_VERSION"
+MINIKUBE_PATH=$([ "${OS_TYPE}" != "linux" ] && echo "minikube" || echo "/usr/local/bin/minikube-$MINIKUBE_VERSION")

Review comment:
       In linux environment, we are downloading the specific minikube version(e.g. v1.8.2) and set the correct `MINIKUBE_PATH`. However, on Mac, we assume that the minikube is pre-installed and we could directly use the `minikube` command to check status or mounting.

##########
File path: flink-end-to-end-tests/test-scripts/common_kubernetes.sh
##########
@@ -178,21 +180,9 @@ function cleanup {
     stop_kubernetes
 }
 
-function setConsoleLogging {
-    cat >> $FLINK_DIR/conf/log4j.properties <<END
-rootLogger.appenderRef.console.ref = ConsoleAppender
-
-# Log all infos to the console
-appender.console.name = ConsoleAppender
-appender.console.type = CONSOLE
-appender.console.layout.type = PatternLayout
-appender.console.layout.pattern = %d{yyyy-MM-dd HH:mm:ss,SSS} %-5p [%t] %-60c %x - %m%n
-END
-}

Review comment:
       First, `setConsoleLogging` is not used in any native K8s related test scripts. Second, the native K8s is using `flink-console.properties` from release 1.12, which will output logs to console and files simultaneously.

##########
File path: flink-end-to-end-tests/test-scripts/common_kubernetes.sh
##########
@@ -25,7 +25,7 @@ MINIKUBE_START_RETRIES=3
 MINIKUBE_START_BACKOFF=5
 RESULT_HASH="e682ec6622b5e83f2eb614617d5ab2cf"
 MINIKUBE_VERSION="v1.8.2"
-MINIKUBE_PATH="/usr/local/bin/minikube-$MINIKUBE_VERSION"
+MINIKUBE_PATH=$([ "${OS_TYPE}" != "linux" ] && echo "minikube" || echo "/usr/local/bin/minikube-$MINIKUBE_VERSION")

Review comment:
       Currently, when running native K8s related test on Mac, we will get following errors.
   ```
   ./test-scripts/common_kubernetes.sh: line 55: /usr/local/bin/minikube-v1.8.2: No such file or directory
   ****** Please start/stop minikube manually in non-linux environment. ******
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14012: [FLINK-17857][test] Make K8s e2e tests could run on Mac

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14012:
URL: https://github.com/apache/flink/pull/14012#issuecomment-724568763


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5640ffc3f9d141cfcce5cf6a871378774aff803a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9392",
       "triggerID" : "5640ffc3f9d141cfcce5cf6a871378774aff803a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7ad6bfa8606b7d6d82b6edd12a720d2b6c3ce842",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17159",
       "triggerID" : "7ad6bfa8606b7d6d82b6edd12a720d2b6c3ce842",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ec6bda8748f9a4ab81fe59cb1e41beeb53df263e",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17698",
       "triggerID" : "ec6bda8748f9a4ab81fe59cb1e41beeb53df263e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ff7f612cdc6e041f05de9f08f1aadbd103413661",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17832",
       "triggerID" : "ff7f612cdc6e041f05de9f08f1aadbd103413661",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ec6bda8748f9a4ab81fe59cb1e41beeb53df263e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17698) 
   * ff7f612cdc6e041f05de9f08f1aadbd103413661 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17832) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann commented on a change in pull request #14012: [FLINK-17857][test] Make K8s e2e tests could run on Mac

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #14012:
URL: https://github.com/apache/flink/pull/14012#discussion_r620109094



##########
File path: flink-end-to-end-tests/test-scripts/common_kubernetes.sh
##########
@@ -25,7 +25,7 @@ MINIKUBE_START_RETRIES=3
 MINIKUBE_START_BACKOFF=5
 RESULT_HASH="e682ec6622b5e83f2eb614617d5ab2cf"
 MINIKUBE_VERSION="v1.8.2"
-MINIKUBE_PATH="/usr/local/bin/minikube-$MINIKUBE_VERSION"
+MINIKUBE_PATH=$([ "${OS_TYPE}" != "linux" ] && echo "minikube" || echo "/usr/local/bin/minikube-$MINIKUBE_VERSION")

Review comment:
       Is `v1.8.2` strictly required? If yes, then we might wanna check on MacOS that `minikube` is actually the correct version. I for example have `1.15.1` installed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14012: [FLINK-17857][test] Make K8s e2e tests could run on Mac

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14012:
URL: https://github.com/apache/flink/pull/14012#issuecomment-724568763


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5640ffc3f9d141cfcce5cf6a871378774aff803a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9392",
       "triggerID" : "5640ffc3f9d141cfcce5cf6a871378774aff803a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7ad6bfa8606b7d6d82b6edd12a720d2b6c3ce842",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17159",
       "triggerID" : "7ad6bfa8606b7d6d82b6edd12a720d2b6c3ce842",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ec6bda8748f9a4ab81fe59cb1e41beeb53df263e",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17698",
       "triggerID" : "ec6bda8748f9a4ab81fe59cb1e41beeb53df263e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ff7f612cdc6e041f05de9f08f1aadbd103413661",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ff7f612cdc6e041f05de9f08f1aadbd103413661",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ec6bda8748f9a4ab81fe59cb1e41beeb53df263e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17698) 
   * ff7f612cdc6e041f05de9f08f1aadbd103413661 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14012: [FLINK-17857][test] Make K8s e2e tests could run on Mac

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14012:
URL: https://github.com/apache/flink/pull/14012#issuecomment-724568763


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5640ffc3f9d141cfcce5cf6a871378774aff803a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5640ffc3f9d141cfcce5cf6a871378774aff803a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5640ffc3f9d141cfcce5cf6a871378774aff803a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14012: [FLINK-17857][test] Make K8s e2e tests could run on Mac

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14012:
URL: https://github.com/apache/flink/pull/14012#issuecomment-724568763


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5640ffc3f9d141cfcce5cf6a871378774aff803a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9392",
       "triggerID" : "5640ffc3f9d141cfcce5cf6a871378774aff803a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7ad6bfa8606b7d6d82b6edd12a720d2b6c3ce842",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17159",
       "triggerID" : "7ad6bfa8606b7d6d82b6edd12a720d2b6c3ce842",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7ad6bfa8606b7d6d82b6edd12a720d2b6c3ce842 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17159) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wangyang0918 commented on pull request #14012: [FLINK-17857][test] Make K8s e2e tests could run on Mac

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #14012:
URL: https://github.com/apache/flink/pull/14012#issuecomment-826273762


   Rebase latest master and force pushed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wangyang0918 commented on a change in pull request #14012: [FLINK-17857][test] Make K8s e2e tests could run on Mac

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #14012:
URL: https://github.com/apache/flink/pull/14012#discussion_r619765557



##########
File path: flink-end-to-end-tests/test-scripts/common_kubernetes.sh
##########
@@ -178,21 +180,9 @@ function cleanup {
     stop_kubernetes
 }
 
-function setConsoleLogging {
-    cat >> $FLINK_DIR/conf/log4j.properties <<END
-rootLogger.appenderRef.console.ref = ConsoleAppender
-
-# Log all infos to the console
-appender.console.name = ConsoleAppender
-appender.console.type = CONSOLE
-appender.console.layout.type = PatternLayout
-appender.console.layout.pattern = %d{yyyy-MM-dd HH:mm:ss,SSS} %-5p [%t] %-60c %x - %m%n
-END
-}

Review comment:
       First, `setConsoleLogging` is not used in any native K8s related test scripts. Second, the native K8s is using `flink-console.properties` from release 1.12, which will output logs to console and files simultaneously.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wangyang0918 commented on pull request #14012: [FLINK-17857][test] Make K8s e2e tests could run on Mac

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #14012:
URL: https://github.com/apache/flink/pull/14012#issuecomment-834461988


   cc @tillrohrmann I have updated this PR.
   
   This PR should rebase the master after #15849 is merged. Otherwise, the `test_kubernetes_itcases.sh` will fail.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wangyang0918 commented on a change in pull request #14012: [FLINK-17857][test] Make K8s e2e tests could run on Mac

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #14012:
URL: https://github.com/apache/flink/pull/14012#discussion_r619764781



##########
File path: flink-end-to-end-tests/test-scripts/common_kubernetes.sh
##########
@@ -25,7 +25,7 @@ MINIKUBE_START_RETRIES=3
 MINIKUBE_START_BACKOFF=5
 RESULT_HASH="e682ec6622b5e83f2eb614617d5ab2cf"
 MINIKUBE_VERSION="v1.8.2"
-MINIKUBE_PATH="/usr/local/bin/minikube-$MINIKUBE_VERSION"
+MINIKUBE_PATH=$([ "${OS_TYPE}" != "linux" ] && echo "minikube" || echo "/usr/local/bin/minikube-$MINIKUBE_VERSION")

Review comment:
       In linux environment, we are downloading the specific minikube version(e.g. v1.8.2) and set the correct `MINIKUBE_PATH`. However, on Mac, we assume that the minikube is pre-installed and we could directly use the `minikube` command to check status or mounting.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14012: [FLINK-17857][test] Make K8s e2e tests could run on Mac

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14012:
URL: https://github.com/apache/flink/pull/14012#issuecomment-724568763






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wangyang0918 commented on pull request #14012: [FLINK-17857][test] Make K8s e2e tests could run on Mac

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #14012:
URL: https://github.com/apache/flink/pull/14012#issuecomment-724568816


   cc @rmetzger could you please have a look at your convenience?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14012: [FLINK-17857][test] Make K8s e2e tests could run on Mac

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14012:
URL: https://github.com/apache/flink/pull/14012#issuecomment-724568763


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5640ffc3f9d141cfcce5cf6a871378774aff803a",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9392",
       "triggerID" : "5640ffc3f9d141cfcce5cf6a871378774aff803a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5640ffc3f9d141cfcce5cf6a871378774aff803a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9392) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann commented on a change in pull request #14012: [FLINK-17857][test] Make K8s e2e tests could run on Mac

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #14012:
URL: https://github.com/apache/flink/pull/14012#discussion_r620113431



##########
File path: flink-end-to-end-tests/test-scripts/common_kubernetes.sh
##########
@@ -178,21 +180,9 @@ function cleanup {
     stop_kubernetes
 }
 
-function setConsoleLogging {
-    cat >> $FLINK_DIR/conf/log4j.properties <<END
-rootLogger.appenderRef.console.ref = ConsoleAppender
-
-# Log all infos to the console
-appender.console.name = ConsoleAppender
-appender.console.type = CONSOLE
-appender.console.layout.type = PatternLayout
-appender.console.layout.pattern = %d{yyyy-MM-dd HH:mm:ss,SSS} %-5p [%t] %-60c %x - %m%n
-END
-}

Review comment:
       I noticed that we don't log any information when running `KubernetesLeaderElectionAndRetrievalITCase`. Could it be that we are using `log4j-test.properties` when running these tests because we use maven? Maybe we should set the log level to `INFO` in order to see the logs. Alternatively, we would have to use a log4j file which configures a file for the output which is then uploaded when the e2e fail (similarly to what we do when running the unit/integration tests which write into `mvn-1.log` and `mvn-2.log`. I think we use https://github.com/apache/flink/blob/master/tools/ci/log4j.properties.
   
   Maybe we should exactly do this and use https://github.com/apache/flink/blob/master/tools/ci/log4j.properties for the logging configuration for the e2e tests which use maven to run them.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wangyang0918 commented on a change in pull request #14012: [FLINK-17857][test] Make K8s e2e tests could run on Mac

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #14012:
URL: https://github.com/apache/flink/pull/14012#discussion_r619765707



##########
File path: flink-end-to-end-tests/test-scripts/common_kubernetes.sh
##########
@@ -25,7 +25,7 @@ MINIKUBE_START_RETRIES=3
 MINIKUBE_START_BACKOFF=5
 RESULT_HASH="e682ec6622b5e83f2eb614617d5ab2cf"
 MINIKUBE_VERSION="v1.8.2"
-MINIKUBE_PATH="/usr/local/bin/minikube-$MINIKUBE_VERSION"
+MINIKUBE_PATH=$([ "${OS_TYPE}" != "linux" ] && echo "minikube" || echo "/usr/local/bin/minikube-$MINIKUBE_VERSION")

Review comment:
       Currently, when running native K8s related test on Mac, we will get following errors.
   ```
   ./test-scripts/common_kubernetes.sh: line 55: /usr/local/bin/minikube-v1.8.2: No such file or directory
   ****** Please start/stop minikube manually in non-linux environment. ******
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wangyang0918 commented on a change in pull request #14012: [FLINK-17857][test] Make K8s e2e tests could run on Mac

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #14012:
URL: https://github.com/apache/flink/pull/14012#discussion_r621935800



##########
File path: flink-end-to-end-tests/test-scripts/common_kubernetes.sh
##########
@@ -25,7 +25,7 @@ MINIKUBE_START_RETRIES=3
 MINIKUBE_START_BACKOFF=5
 RESULT_HASH="e682ec6622b5e83f2eb614617d5ab2cf"
 MINIKUBE_VERSION="v1.8.2"
-MINIKUBE_PATH="/usr/local/bin/minikube-$MINIKUBE_VERSION"
+MINIKUBE_PATH=$([ "${OS_TYPE}" != "linux" ] && echo "minikube" || echo "/usr/local/bin/minikube-$MINIKUBE_VERSION")

Review comment:
       I remember the azure pipeline updated the provided minikube version silently(a not stable version) and that leads to all the K8s related tests failed. This is why we have pinned the minikube version to `v1.8.2`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14012: [FLINK-17857][test] Make K8s e2e tests could run on Mac

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14012:
URL: https://github.com/apache/flink/pull/14012#issuecomment-724568763


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5640ffc3f9d141cfcce5cf6a871378774aff803a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9392",
       "triggerID" : "5640ffc3f9d141cfcce5cf6a871378774aff803a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7ad6bfa8606b7d6d82b6edd12a720d2b6c3ce842",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17159",
       "triggerID" : "7ad6bfa8606b7d6d82b6edd12a720d2b6c3ce842",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ec6bda8748f9a4ab81fe59cb1e41beeb53df263e",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17698",
       "triggerID" : "ec6bda8748f9a4ab81fe59cb1e41beeb53df263e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7ad6bfa8606b7d6d82b6edd12a720d2b6c3ce842 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17159) 
   * ec6bda8748f9a4ab81fe59cb1e41beeb53df263e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17698) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14012: [FLINK-17857][test] Make K8s e2e tests could run on Mac

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14012:
URL: https://github.com/apache/flink/pull/14012#issuecomment-724568763


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5640ffc3f9d141cfcce5cf6a871378774aff803a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9392",
       "triggerID" : "5640ffc3f9d141cfcce5cf6a871378774aff803a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7ad6bfa8606b7d6d82b6edd12a720d2b6c3ce842",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17159",
       "triggerID" : "7ad6bfa8606b7d6d82b6edd12a720d2b6c3ce842",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ec6bda8748f9a4ab81fe59cb1e41beeb53df263e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17698",
       "triggerID" : "ec6bda8748f9a4ab81fe59cb1e41beeb53df263e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ff7f612cdc6e041f05de9f08f1aadbd103413661",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17832",
       "triggerID" : "ff7f612cdc6e041f05de9f08f1aadbd103413661",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ff7f612cdc6e041f05de9f08f1aadbd103413661 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17832) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14012: [FLINK-17857][test] Make K8s e2e tests could run on Mac

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14012:
URL: https://github.com/apache/flink/pull/14012#issuecomment-724568763


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5640ffc3f9d141cfcce5cf6a871378774aff803a",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9392",
       "triggerID" : "5640ffc3f9d141cfcce5cf6a871378774aff803a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7ad6bfa8606b7d6d82b6edd12a720d2b6c3ce842",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "7ad6bfa8606b7d6d82b6edd12a720d2b6c3ce842",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5640ffc3f9d141cfcce5cf6a871378774aff803a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9392) 
   * 7ad6bfa8606b7d6d82b6edd12a720d2b6c3ce842 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14012: [FLINK-17857][test] Make K8s e2e tests could run on Mac

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14012:
URL: https://github.com/apache/flink/pull/14012#issuecomment-724568763


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5640ffc3f9d141cfcce5cf6a871378774aff803a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9392",
       "triggerID" : "5640ffc3f9d141cfcce5cf6a871378774aff803a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5640ffc3f9d141cfcce5cf6a871378774aff803a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9392) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann commented on a change in pull request #14012: [FLINK-17857][test] Make K8s e2e tests could run on Mac

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #14012:
URL: https://github.com/apache/flink/pull/14012#discussion_r619364433



##########
File path: flink-end-to-end-tests/test-scripts/common_kubernetes.sh
##########
@@ -25,7 +25,7 @@ MINIKUBE_START_RETRIES=3
 MINIKUBE_START_BACKOFF=5
 RESULT_HASH="e682ec6622b5e83f2eb614617d5ab2cf"
 MINIKUBE_VERSION="v1.8.2"
-MINIKUBE_PATH="/usr/local/bin/minikube-$MINIKUBE_VERSION"
+MINIKUBE_PATH=$([ "${OS_TYPE}" != "linux" ] && echo "minikube" || echo "/usr/local/bin/minikube-$MINIKUBE_VERSION")

Review comment:
       Why is this change necessary @wangyang0918?

##########
File path: flink-end-to-end-tests/test-scripts/common_kubernetes.sh
##########
@@ -178,21 +180,9 @@ function cleanup {
     stop_kubernetes
 }
 
-function setConsoleLogging {
-    cat >> $FLINK_DIR/conf/log4j.properties <<END
-rootLogger.appenderRef.console.ref = ConsoleAppender
-
-# Log all infos to the console
-appender.console.name = ConsoleAppender
-appender.console.type = CONSOLE
-appender.console.layout.type = PatternLayout
-appender.console.layout.pattern = %d{yyyy-MM-dd HH:mm:ss,SSS} %-5p [%t] %-60c %x - %m%n
-END
-}

Review comment:
       Why don't we need this logging anymore?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14012: [FLINK-17857][test] Make K8s e2e tests could run on Mac

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14012:
URL: https://github.com/apache/flink/pull/14012#issuecomment-724568763


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5640ffc3f9d141cfcce5cf6a871378774aff803a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9392",
       "triggerID" : "5640ffc3f9d141cfcce5cf6a871378774aff803a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7ad6bfa8606b7d6d82b6edd12a720d2b6c3ce842",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17159",
       "triggerID" : "7ad6bfa8606b7d6d82b6edd12a720d2b6c3ce842",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ec6bda8748f9a4ab81fe59cb1e41beeb53df263e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ec6bda8748f9a4ab81fe59cb1e41beeb53df263e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7ad6bfa8606b7d6d82b6edd12a720d2b6c3ce842 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17159) 
   * ec6bda8748f9a4ab81fe59cb1e41beeb53df263e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wangyang0918 commented on a change in pull request #14012: [FLINK-17857][test] Make K8s e2e tests could run on Mac

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #14012:
URL: https://github.com/apache/flink/pull/14012#discussion_r620401426



##########
File path: flink-end-to-end-tests/test-scripts/common_kubernetes.sh
##########
@@ -178,21 +180,9 @@ function cleanup {
     stop_kubernetes
 }
 
-function setConsoleLogging {
-    cat >> $FLINK_DIR/conf/log4j.properties <<END
-rootLogger.appenderRef.console.ref = ConsoleAppender
-
-# Log all infos to the console
-appender.console.name = ConsoleAppender
-appender.console.type = CONSOLE
-appender.console.layout.type = PatternLayout
-appender.console.layout.pattern = %d{yyyy-MM-dd HH:mm:ss,SSS} %-5p [%t] %-60c %x - %m%n
-END
-}

Review comment:
       I will have a look on the logging of unit test and try to correct the logging configuration for e2e tests that use `run_mvn`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wangyang0918 commented on pull request #14012: [FLINK-17857][test] Make K8s e2e tests could run on Mac

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #14012:
URL: https://github.com/apache/flink/pull/14012#issuecomment-826273762


   Rebase latest master and force pushed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann commented on a change in pull request #14012: [FLINK-17857][test] Make K8s e2e tests could run on Mac

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #14012:
URL: https://github.com/apache/flink/pull/14012#discussion_r620431654



##########
File path: flink-end-to-end-tests/test-scripts/common_kubernetes.sh
##########
@@ -25,7 +25,7 @@ MINIKUBE_START_RETRIES=3
 MINIKUBE_START_BACKOFF=5
 RESULT_HASH="e682ec6622b5e83f2eb614617d5ab2cf"
 MINIKUBE_VERSION="v1.8.2"
-MINIKUBE_PATH="/usr/local/bin/minikube-$MINIKUBE_VERSION"
+MINIKUBE_PATH=$([ "${OS_TYPE}" != "linux" ] && echo "minikube" || echo "/usr/local/bin/minikube-$MINIKUBE_VERSION")

Review comment:
       Then we could maybe change it so that we use whatever version is available and if `minikube` is not available, then we try to download minikube on Linux. On MacOS we fail with a descriptive message. This would be a somewhat consistent behaviour.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wangyang0918 commented on a change in pull request #14012: [FLINK-17857][test] Make K8s e2e tests could run on Mac

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #14012:
URL: https://github.com/apache/flink/pull/14012#discussion_r620365129



##########
File path: flink-end-to-end-tests/test-scripts/common_kubernetes.sh
##########
@@ -25,7 +25,7 @@ MINIKUBE_START_RETRIES=3
 MINIKUBE_START_BACKOFF=5
 RESULT_HASH="e682ec6622b5e83f2eb614617d5ab2cf"
 MINIKUBE_VERSION="v1.8.2"
-MINIKUBE_PATH="/usr/local/bin/minikube-$MINIKUBE_VERSION"
+MINIKUBE_PATH=$([ "${OS_TYPE}" != "linux" ] && echo "minikube" || echo "/usr/local/bin/minikube-$MINIKUBE_VERSION")

Review comment:
       Hmm. `v1.8.2` is not strictly required. We are using this version just because it is the latest stable version when we introduce the tests.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14012: [FLINK-17857][test] Make K8s e2e tests could run on Mac

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14012:
URL: https://github.com/apache/flink/pull/14012#issuecomment-724553515


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit ff7f612cdc6e041f05de9f08f1aadbd103413661 (Sat Aug 28 11:20:35 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann closed pull request #14012: [FLINK-17857][test] Make K8s e2e tests could run on Mac

Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #14012:
URL: https://github.com/apache/flink/pull/14012


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann commented on a change in pull request #14012: [FLINK-17857][test] Make K8s e2e tests could run on Mac

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #14012:
URL: https://github.com/apache/flink/pull/14012#discussion_r622142788



##########
File path: flink-end-to-end-tests/test-scripts/common_kubernetes.sh
##########
@@ -25,7 +25,7 @@ MINIKUBE_START_RETRIES=3
 MINIKUBE_START_BACKOFF=5
 RESULT_HASH="e682ec6622b5e83f2eb614617d5ab2cf"
 MINIKUBE_VERSION="v1.8.2"
-MINIKUBE_PATH="/usr/local/bin/minikube-$MINIKUBE_VERSION"
+MINIKUBE_PATH=$([ "${OS_TYPE}" != "linux" ] && echo "minikube" || echo "/usr/local/bin/minikube-$MINIKUBE_VERSION")

Review comment:
       Would it make sense to check whether there is a `minikube` version and if whether it is a version which works? In this case we could use it. If not, then the system could try to download and install `minikube` `v1.8.2` if it runs on Linux.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14012: [FLINK-17857][test] Make K8s e2e tests could run on Mac

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14012:
URL: https://github.com/apache/flink/pull/14012#issuecomment-724553515


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 5640ffc3f9d141cfcce5cf6a871378774aff803a (Tue Nov 10 08:42:54 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org