You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "He-Pin (via GitHub)" <gi...@apache.org> on 2026/06/14 12:17:49 UTC

[PR] chore: unify formatter config - standardize aliases, add JDK17 setting [pekko-persistence-r2dbc]

He-Pin opened a new pull request, #402:
URL: https://github.com/apache/pekko-persistence-r2dbc/pull/402

   ### Motivation
   Align formatter plugins, command aliases, and JDK settings with other pekko sub-projects to reduce maintenance burden and ensure consistent formatting configuration across the ecosystem.
   
   ### Modification
   - Standardize `checkCodeStyle`/`applyCodeStyle` command aliases
   - Add `ThisBuild / javafmtFormatterCompatibleJavaVersion := 17` where missing
   - Replace custom `verifyCodeFmt` tasks with standard aliases where applicable
   - Upgrade sbt-java-formatter plugin where needed
   
   ### Result
   Consistent formatter configuration across all pekko sub-projects, enabling unified `sbt checkCodeStyle` / `sbt applyCodeStyle` workflow.
   
   ### Tests
   Not run - build config change only
   
   ### References
   None - formatter unification across pekko sub-projects


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] chore: unify formatter config - standardize aliases, add JDK17 setting [pekko-persistence-r2dbc]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #402:
URL: https://github.com/apache/pekko-persistence-r2dbc/pull/402#issuecomment-4708172217

   Restored license headers in all 3 remaining files: BlogPostQuery.java, MultiPluginDocExample.java, BlogPostTitleColumn.java. All doc test Java files now preserve original multi-line copyright headers.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] chore: unify formatter config - standardize aliases, add JDK17 setting [pekko-persistence-r2dbc]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin merged PR #402:
URL: https://github.com/apache/pekko-persistence-r2dbc/pull/402


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] chore: unify formatter config - standardize aliases, add JDK17 setting [pekko-persistence-r2dbc]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #402:
URL: https://github.com/apache/pekko-persistence-r2dbc/pull/402#issuecomment-4717695009

   Addressed all CR feedback in commit 9d26176:
   
   **License headers** (comments #1, #2, #3): All jdocs Java files reverted to original formatting — multi-line copyright headers preserved intact. Added `javafmt / excludeFilter` for `/jdocs/` files since Paradox snippet markers between imports and copyright headers are incompatible with google-java-format.
   
   **MultiPluginDocExample.java** (comment #4): Moved `public` to the `static class MyEntity` declaration line → `public static class MyEntity extends EventSourcedBehavior<...>`. The `// #withPlugins` Paradox marker remains before the class declaration for correct snippet rendering.
   
   **Verification**:
   - `sbt checkCodeStyle` ✅ (scalafmt + javafmt + headers)
   - `sbt docs/Test/compile` ✅


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] chore: unify formatter config - standardize aliases, add JDK17 setting [pekko-persistence-r2dbc]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #402:
URL: https://github.com/apache/pekko-persistence-r2dbc/pull/402#discussion_r3420002026


##########
docs/src/test/java/jdocs/home/MultiPluginDocExample.java:
##########
@@ -20,22 +20,20 @@
 
 public class MultiPluginDocExample {
 
-  static
+  public
   // #withPlugins
-  public class MyEntity extends EventSourcedBehavior<MyEntity.Command, MyEntity.Event, MyEntity.State> {
+  static class MyEntity

Review Comment:
   Done — moved `public` to the `static class MyEntity` line so it reads `public static class MyEntity extends EventSourcedBehavior<...>`. The `// #withPlugins` Paradox marker remains before the class declaration.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] chore: unify formatter config - standardize aliases, add JDK17 setting [pekko-persistence-r2dbc]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #402:
URL: https://github.com/apache/pekko-persistence-r2dbc/pull/402#discussion_r3419845620


##########
docs/src/test/java/jdocs/home/MultiPluginDocExample.java:
##########
@@ -20,22 +20,20 @@
 
 public class MultiPluginDocExample {
 
-  static
+  public
   // #withPlugins
-  public class MyEntity extends EventSourcedBehavior<MyEntity.Command, MyEntity.Event, MyEntity.State> {
+  static class MyEntity

Review Comment:
   can we move the 'public' on line 23 to here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] chore: unify formatter config - standardize aliases, add JDK17 setting [pekko-persistence-r2dbc]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #402:
URL: https://github.com/apache/pekko-persistence-r2dbc/pull/402#discussion_r3412194204


##########
docs/src/test/java/jdocs/home/state/BlogPostCounts.java:
##########
@@ -7,10 +7,7 @@
  * This file is part of the Apache Pekko project, which was derived from Akka.
  */
 
-/**
- * Copyright (C) 2022 Lightbend Inc. <https://www.lightbend.com>
- */
-
+/** Copyright (C) 2022 Lightbend Inc. <https://www.lightbend.com> */

Review Comment:
   undo this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] chore: unify formatter config - standardize aliases, add JDK17 setting [pekko-persistence-r2dbc]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #402:
URL: https://github.com/apache/pekko-persistence-r2dbc/pull/402#discussion_r3413535616


##########
docs/src/test/java/jdocs/home/state/BlogPostQuery.java:
##########
@@ -7,10 +7,7 @@
  * This file is part of the Apache Pekko project, which was derived from Akka.
  */
 
-/**
- * Copyright (C) 2022 Lightbend Inc. <https://www.lightbend.com>
- */
-
+/** Copyright (C) 2022 Lightbend Inc. <https://www.lightbend.com> */

Review Comment:
   still modifying license headers



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] chore: unify formatter config - standardize aliases, add JDK17 setting [pekko-persistence-r2dbc]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #402:
URL: https://github.com/apache/pekko-persistence-r2dbc/pull/402#discussion_r3412197392


##########
docs/src/test/java/jdocs/home/state/BlogPostJsonColumn.java:
##########
@@ -7,10 +7,7 @@
  * This file is part of the Apache Pekko project, which was derived from Akka.
  */
 
-/**
- * Copyright (C) 2022 Lightbend Inc. <https://www.lightbend.com>
- */
-
+/** Copyright (C) 2022 Lightbend Inc. <https://www.lightbend.com> */

Review Comment:
   license headers should not be modified



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org