[GitHub] [cordova-plugin-screen-orientation] jaydrogers commented on a diff in pull request #102: fix(ios): #100 - Resolve orientation issues on iOS 16+

[GitBox <gi...@apache.org>]

jaydrogers commented on code in PR #102:
URL: https://github.com/apache/cordova-plugin-screen-orientation/pull/102#discussion_r977955315


##########
src/ios/CDVOrientation.m:
##########
@@ -80,7 +80,13 @@ -(void)screenOrientation:(CDVInvokedUrlCommand *)command
             }
             if (value != nil) {
                 _isLocked = true;
-                [[UIDevice currentDevice] setValue:value forKey:@"orientation"];
+                if (@available(iOS 16.0, *)) {
+                    #if __IPHONE_OS_VERSION_MAX_ALLOWED > __IPHONE_15_5 // Xcode 14 and iOS 16, or greater
+                        [self.viewController setNeedsUpdateOfSupportedInterfaceOrientations];
+                    #endif
+                } else {
+                    [UINavigationController attemptRotationToDeviceOrientation];

Review Comment:
   Do you want me to update line 88 to that?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org