[GitHub] [spark] cloud-fan commented on pull request #31273: [SPARK-34152][SQL] Make CreateViewStatement.child to be LogicalPlan's children so that it's resolved in analyze phase

[GitBox <gi...@apache.org>]

cloud-fan commented on pull request #31273:
URL: https://github.com/apache/spark/pull/31273#issuecomment-783246992


   Looks pretty good. My last concern is changing the `View` signature to hold temp views, as it leads to many other changes. I agree it's a bit overkill to add another wrapper node for temp views, but can we use a special `CatalogTable` to indicate it's temp view? so that we don't need to change the `View` signature.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org