You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/11/05 14:43:22 UTC

[GitHub] [arrow-datafusion] Jimexist opened a new pull request #1251: fix 1250, add editor support for datafusion cli with validation

Jimexist opened a new pull request #1251:
URL: https://github.com/apache/arrow-datafusion/pull/1251


   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #1250
   
    # Rationale for this change
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   # What changes are included in this PR?
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-datafusion] alamb commented on pull request #1251: fix 1250, add editor support for datafusion cli with validation

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1251:
URL: https://github.com/apache/arrow-datafusion/pull/1251#issuecomment-962431683


   I started playing around with this locally -- it is very cool. Going to review it now more carefully


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-datafusion] Jimexist commented on pull request #1251: fix 1250, add editor support for datafusion cli with validation

Posted by GitBox <gi...@apache.org>.
Jimexist commented on pull request #1251:
URL: https://github.com/apache/arrow-datafusion/pull/1251#issuecomment-962442943


   > I read the code and played around with this and it was very cool 👍
   > 
   > Can't wait to see something like SQL autocompletion 😍
   > 
   > I wonder if it would be possible to write tests for this somehow -- not because it doesn't work now, but this is the kind of cool behavior that could easily get messed up if/ when we add new behaviors / auto complete
   
   agreed, however i cannot find easy way to unit test the editor as this requires user input simulation. will try later if i have more time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-datafusion] Jimexist merged pull request #1251: fix 1250, add editor support for datafusion cli with validation

Posted by GitBox <gi...@apache.org>.
Jimexist merged pull request #1251:
URL: https://github.com/apache/arrow-datafusion/pull/1251


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org