You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zhangstar333 (via GitHub)" <gi...@apache.org> on 2024/01/16 12:55:29 UTC
[PR] [function](char) change char function behaviour same with mysql [doris]
zhangstar333 opened a new pull request, #30034:
URL: https://github.com/apache/doris/pull/30034
## Proposed changes
select char(0) = '\0';
should return true;
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [function](char) change char function behaviour same with mysql [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #30034:
URL: https://github.com/apache/doris/pull/30034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [function](char) change char function behaviour same with mysql [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30034:
URL: https://github.com/apache/doris/pull/30034#issuecomment-1893869258
TeamCity be ut coverage result:
Function Coverage: 36.67% (8648/23581)
Line Coverage: 28.73% (70611/245787)
Region Coverage: 27.62% (36436/131932)
Branch Coverage: 24.33% (18637/76592)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d0b70afe284c51d989ea86c633496b4b2cf41b6c_d0b70afe284c51d989ea86c633496b4b2cf41b6c/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [function](char) change char function behaviour same with mysql [doris]
Posted by "zhangstar333 (via GitHub)" <gi...@apache.org>.
zhangstar333 commented on PR #30034:
URL: https://github.com/apache/doris/pull/30034#issuecomment-1893708091
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [function](char) change char function behaviour same with mysql [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30034:
URL: https://github.com/apache/doris/pull/30034#issuecomment-1893841610
<details>
<summary>TPC-H: <b>Total hot run time: 38946 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d0b70afe284c51d989ea86c633496b4b2cf41b6c, data reload: false
------ Round 1 ----------------------------------
q1 17661 5226 5773 5226
q2 2051 140 131 131
q3 10745 1159 1139 1139
q4 10266 808 787 787
q5 7778 3196 3155 3155
q6 198 118 120 118
q7 860 490 490 490
q8 9209 1946 1965 1946
q9 7297 6389 6357 6357
q10 8173 3107 3055 3055
q11 437 210 205 205
q12 364 188 190 188
q13 17993 3353 3319 3319
q14 234 204 211 204
q15 548 511 498 498
q16 431 369 378 369
q17 952 504 509 504
q18 7512 7053 6830 6830
q19 1566 1409 1414 1409
q20 560 312 304 304
q21 2911 2405 2408 2405
q22 367 310 307 307
Total cold run time: 108113 ms
Total hot run time: 38946 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5475 5447 5298 5298
q2 327 219 218 218
q3 3306 3234 3232 3232
q4 2049 2036 1999 1999
q5 6030 5934 5823 5823
q6 199 115 115 115
q7 2276 1867 1893 1867
q8 3244 3381 3391 3381
q9 8900 8980 8749 8749
q10 3875 3869 3828 3828
q11 550 447 437 437
q12 810 599 618 599
q13 16921 3148 3127 3127
q14 279 243 275 243
q15 540 510 505 505
q16 503 475 485 475
q17 1864 1858 1855 1855
q18 9564 14565 9638 9638
q19 27837 1615 1540 1540
q20 4589 1928 1919 1919
q21 15367 5406 5402 5402
q22 1110 537 499 499
Total cold run time: 115615 ms
Total hot run time: 60749 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [function](char) change char function behaviour same with mysql [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30034:
URL: https://github.com/apache/doris/pull/30034#issuecomment-1893867191
<details>
<summary>TPC-DS: <b>Total hot run time: 177038 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d0b70afe284c51d989ea86c633496b4b2cf41b6c, data reload: false
query1 943 335 325 325
query2 6562 2077 1853 1853
query3 6704 212 220 212
query4 32756 22366 22094 22094
query5 6853 603 548 548
query6 252 167 162 162
query7 4601 264 263 263
query8 224 175 177 175
query9 8355 2569 2549 2549
query10 416 229 224 224
query11 16668 15615 15570 15570
query12 123 68 68 68
query13 1686 382 368 368
query14 10428 6991 6858 6858
query15 210 178 183 178
query16 4611 240 231 231
query17 980 487 467 467
query18 1788 261 250 250
query19 178 141 140 140
query20 74 75 63 63
query21 183 127 128 127
query22 4939 4783 4831 4783
query23 31720 30944 30707 30707
query24 12671 2838 2772 2772
query25 566 320 304 304
query26 1786 143 149 143
query27 3195 271 281 271
query28 7181 1824 1814 1814
query29 2132 631 615 615
query30 289 135 137 135
query31 911 747 788 747
query32 79 50 48 48
query33 708 216 213 213
query34 1156 453 452 452
query35 894 771 716 716
query36 1449 1247 1273 1247
query37 172 60 59 59
query38 3397 3264 3215 3215
query39 1322 1267 1267 1267
query40 342 90 85 85
query41 38 32 33 32
query42 94 84 87 84
query43 543 549 476 476
query44 1162 688 703 688
query45 196 184 179 179
query46 1054 670 673 670
query47 1707 1570 1578 1570
query48 380 323 325 323
query49 1221 281 282 281
query50 687 311 308 308
query51 5315 5205 5183 5183
query52 90 78 81 78
query53 323 250 256 250
query54 870 431 441 431
query55 88 78 77 77
query56 181 171 162 162
query57 1018 954 932 932
query58 190 166 163 163
query59 3018 2833 2795 2795
query60 212 181 192 181
query61 86 82 84 82
query62 643 402 400 400
query63 290 259 263 259
query64 6171 1804 1816 1804
query65 3353 3238 3245 3238
query66 1396 329 306 306
query67 15384 15019 15113 15019
query68 10746 541 509 509
query69 621 302 295 295
query70 1662 1571 1479 1479
query71 560 234 222 222
query72 4979 2784 2826 2784
query73 2130 317 320 317
query74 7019 6255 6353 6255
query75 4745 2361 2338 2338
query76 6247 1051 1042 1042
query77 650 237 247 237
query78 9097 8911 8668 8668
query79 1031 519 511 511
query80 529 309 323 309
query81 442 205 212 205
query82 202 85 76 76
query83 139 125 118 118
query84 272 68 68 68
query85 1048 319 309 309
query86 387 372 365 365
query87 3518 3313 3298 3298
query88 3412 2257 2273 2257
query89 447 369 370 369
query90 1973 194 190 190
query91 152 129 121 121
query92 55 43 46 43
query93 2702 403 431 403
query94 1236 156 156 156
query95 510 457 444 444
query96 627 327 338 327
query97 4282 4123 4145 4123
query98 196 185 180 180
query99 1012 731 735 731
Total cold run time: 297842 ms
Total hot run time: 177038 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [function](char) change char function behaviour same with mysql [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30034:
URL: https://github.com/apache/doris/pull/30034#issuecomment-1893703362
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [function](char) change char function behaviour same with mysql [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30034:
URL: https://github.com/apache/doris/pull/30034#issuecomment-1893883526
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit d0b70afe284c51d989ea86c633496b4b2cf41b6c with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 15.0 seconds inserted 10000000 Rows, about 666K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [function](char) change char function behaviour same with mysql [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30034:
URL: https://github.com/apache/doris/pull/30034#issuecomment-1893711829
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [function](char) change char function behaviour same with mysql [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30034:
URL: https://github.com/apache/doris/pull/30034#issuecomment-1893711975
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [function](char) change char function behaviour same with mysql [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30034:
URL: https://github.com/apache/doris/pull/30034#issuecomment-1893877538
<details>
<summary>ClickBench: <b>Total hot run time: 30.7 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d0b70afe284c51d989ea86c633496b4b2cf41b6c, data reload: false
query1 0.02 0.02 0.02
query2 0.06 0.03 0.02
query3 0.22 0.05 0.06
query4 1.68 0.08 0.06
query5 0.53 0.52 0.53
query6 1.32 0.64 0.63
query7 0.02 0.01 0.01
query8 0.04 0.02 0.02
query9 0.56 0.50 0.50
query10 0.57 0.57 0.54
query11 0.12 0.09 0.09
query12 0.11 0.09 0.09
query13 0.60 0.60 0.59
query14 0.77 0.80 0.79
query15 0.80 0.77 0.77
query16 0.37 0.40 0.38
query17 1.00 1.00 1.02
query18 0.25 0.25 0.24
query19 1.88 1.77 1.82
query20 0.01 0.01 0.01
query21 15.42 0.61 0.58
query22 2.33 2.45 1.72
query23 17.47 0.77 0.80
query24 2.47 1.00 0.99
query25 0.34 0.13 0.23
query26 0.49 0.14 0.13
query27 0.07 0.05 0.06
query28 11.64 0.78 0.77
query29 12.53 3.19 3.28
query30 0.65 0.56 0.52
query31 2.79 0.33 0.35
query32 3.39 0.49 0.48
query33 3.25 3.25 3.23
query34 15.78 4.19 4.24
query35 4.22 4.21 4.19
query36 1.14 1.08 1.08
query37 0.06 0.05 0.05
query38 0.03 0.03 0.03
query39 0.02 0.01 0.02
query40 0.15 0.12 0.13
query41 0.08 0.01 0.01
query42 0.02 0.02 0.01
query43 0.02 0.02 0.02
Total cold run time: 105.29 s
Total hot run time: 30.7 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org