[jira] [Updated] (SAMZA-75) Change log dir and container name defaults in run-class.sh

["Chris Riccomini (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SAMZA-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Riccomini updated SAMZA-75:
---------------------------------

    Attachment: SAMZA-75.0.patch

Attaching a patch.

https://reviews.apache.org/r/15182/

> Change log dir and container name defaults in run-class.sh
> ----------------------------------------------------------
>
>                 Key: SAMZA-75
>                 URL: https://issues.apache.org/jira/browse/SAMZA-75
>             Project: Samza
>          Issue Type: Bug
>          Components: container
>    Affects Versions: 0.6.0
>            Reporter: Chris Riccomini
>            Assignee: Chris Riccomini
>             Fix For: 0.7.0
>
>         Attachments: SAMZA-75.0.patch
>
>
> Samza uses a run-class.sh script to execute all of its code. The run-class.sh script sets default for two Samza-related environment variables:
> SAMZA_LOG_DIR
> SAMZA_CONTAINER_NAME
> The current defaults are:
> SAMZA_LOG_DIR=/tmp
> SAMZA_CONTAINER_NAME= # not defined
> I propose that we change the log dir default to $base_dir, and the container name default to "undefined-samza-container-name".
> The reason I want to do this is that there are cases where these defaults are used, and having an undefined container name leads to a log4j.xml file called ".log" because we're using ${samza.container.name}.log as the file name for log4j rolling file appenders. The reason for the log dir change is that it doesn't make sense to assume that /tmp exists (and is writable, and a sane place to put it, with enough space), and it'd be better to put the log folder somewhere relative to the job package.



--
This message was sent by Atlassian JIRA
(v6.1#6144)