You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by na...@apache.org on 2017/05/04 05:59:08 UTC
samza git commit: SAMZA-1259: LocalApplicationRunner throws exception
when configured with a ProcessorIdGenerator
Repository: samza
Updated Branches:
refs/heads/master 8bcfded46 -> 06b5dbdae
SAMZA-1259: LocalApplicationRunner throws exception when configured with a ProcessorIdGenerator
Minor fix. Unit tests were updated and passed.
Author: Sean McCauliff <sm...@linkedin.com>
Reviewers: Navina Ramesh <nr...@linkedin.com>
Closes #161 from smccauliff/samza-1259
Project: http://git-wip-us.apache.org/repos/asf/samza/repo
Commit: http://git-wip-us.apache.org/repos/asf/samza/commit/06b5dbda
Tree: http://git-wip-us.apache.org/repos/asf/samza/tree/06b5dbda
Diff: http://git-wip-us.apache.org/repos/asf/samza/diff/06b5dbda
Branch: refs/heads/master
Commit: 06b5dbdaec6577644e0204b4f7b5ca91cdb06ab7
Parents: 8bcfded
Author: Sean McCauliff <sm...@linkedin.com>
Authored: Wed May 3 22:58:51 2017 -0700
Committer: nramesh <nr...@linkedin.com>
Committed: Wed May 3 22:58:51 2017 -0700
----------------------------------------------------------------------
.../main/java/org/apache/samza/runtime/LocalApplicationRunner.java | 2 +-
.../java/org/apache/samza/runtime/TestLocalApplicationRunner.java | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/samza/blob/06b5dbda/samza-core/src/main/java/org/apache/samza/runtime/LocalApplicationRunner.java
----------------------------------------------------------------------
diff --git a/samza-core/src/main/java/org/apache/samza/runtime/LocalApplicationRunner.java b/samza-core/src/main/java/org/apache/samza/runtime/LocalApplicationRunner.java
index 3efbdc1..ca4652e 100644
--- a/samza-core/src/main/java/org/apache/samza/runtime/LocalApplicationRunner.java
+++ b/samza-core/src/main/java/org/apache/samza/runtime/LocalApplicationRunner.java
@@ -202,7 +202,7 @@ public class LocalApplicationRunner extends AbstractApplicationRunner {
ApplicationConfig appConfig = new ApplicationConfig(config);
if (appConfig.getProcessorId() != null) {
return appConfig.getProcessorId();
- } else if (appConfig.getAppProcessorIdGeneratorClass() == null) {
+ } else if (appConfig.getAppProcessorIdGeneratorClass() != null) {
ProcessorIdGenerator idGenerator =
ClassLoaderHelper.fromClassName(appConfig.getAppProcessorIdGeneratorClass(),
ProcessorIdGenerator.class);
http://git-wip-us.apache.org/repos/asf/samza/blob/06b5dbda/samza-core/src/test/java/org/apache/samza/runtime/TestLocalApplicationRunner.java
----------------------------------------------------------------------
diff --git a/samza-core/src/test/java/org/apache/samza/runtime/TestLocalApplicationRunner.java b/samza-core/src/test/java/org/apache/samza/runtime/TestLocalApplicationRunner.java
index 210336f..6cd3105 100644
--- a/samza-core/src/test/java/org/apache/samza/runtime/TestLocalApplicationRunner.java
+++ b/samza-core/src/test/java/org/apache/samza/runtime/TestLocalApplicationRunner.java
@@ -199,7 +199,7 @@ public class TestLocalApplicationRunner {
@Test
public void testRunComplete() throws Exception {
final Map<String, String> config = new HashMap<>();
- config.put(ApplicationConfig.PROCESSOR_ID, "0");
+ config.put(ApplicationConfig.APP_PROCESSOR_ID_GENERATOR_CLASS, UUIDGenerator.class.getName());
LocalApplicationRunner runner = new LocalApplicationRunner(new MapConfig(config));
StreamApplication app = mock(StreamApplication.class);
doNothing().when(app).init(anyObject(), anyObject());