You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "kahlstrm (via GitHub)" <gi...@apache.org> on 2024/06/15 10:04:27 UTC
[PR] Remove flaky test case of deferred instance state for served logs [airflow]
kahlstrm opened a new pull request, #40257:
URL: https://github.com/apache/airflow/pull/40257
Relates to #39496 and the aftermath of it.
In that PR tests for served logs were added for other instance states than `TaskInstanceState.RUNNING`, including `TaskInstanceState.UP_FOR_RETRY` (added in the PR) and `TaskInstanceState.DEFERRED` (not added in the PR).
However, as it was briefly discussed in the PR and was later [discovered](https://github.com/apache/airflow/pull/39496#issuecomment-2149692239), the current testing setup does not seem to guarantee consistent behavior for `TaskInstanceState.DEFERRED`, as the tests succeed in local, but fail in the CI.
This PR removes the testing of the state `TaskInstanceState.DEFERRED`, as it was not the main purpose of #39496 but was rather an attempt to add better testing coverage for old behavior cases as well.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove flaky test case of deferred instance state for served logs [airflow]
Posted by "ferruzzi (via GitHub)" <gi...@apache.org>.
ferruzzi commented on PR #40257:
URL: https://github.com/apache/airflow/pull/40257#issuecomment-2174475901
In addition to the comment in the code, could you open an Issue with details so someone might pick it up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove flaky test case of deferred instance state for served logs [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #40257:
URL: https://github.com/apache/airflow/pull/40257#issuecomment-2175577488
> In addition to the comment in the code, could you open an Issue with details so someone might pick it up?
Yeah. that's what we usually do. Create an issue and link to it from the TODO comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org