You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Steve Rowe <sa...@gmail.com> on 2013/07/03 00:12:37 UTC
Re: svn commit: r1499074 - /lucene/dev/trunk/solr/core/src/test/org/apache/solr/core/TestCoreDiscovery.java
After svn up'ing trunk, TestCoreDiscovery.testDuplicateNames (and all other tests in that suite) now pass for me on Windows. - Steve
On Jul 2, 2013, at 3:44 PM, erick@apache.org wrote:
> Author: erick
> Date: Tue Jul 2 19:44:46 2013
> New Revision: 1499074
>
> URL: http://svn.apache.org/r1499074
> Log:
> Fixing another file separator issue, test only
>
> Modified:
> lucene/dev/trunk/solr/core/src/test/org/apache/solr/core/TestCoreDiscovery.java
>
> Modified: lucene/dev/trunk/solr/core/src/test/org/apache/solr/core/TestCoreDiscovery.java
> URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/test/org/apache/solr/core/TestCoreDiscovery.java?rev=1499074&r1=1499073&r2=1499074&view=diff
> ==============================================================================
> --- lucene/dev/trunk/solr/core/src/test/org/apache/solr/core/TestCoreDiscovery.java (original)
> +++ lucene/dev/trunk/solr/core/src/test/org/apache/solr/core/TestCoreDiscovery.java Tue Jul 2 19:44:46 2013
> @@ -184,8 +184,10 @@ public class TestCoreDiscovery extends S
> String message = cause.getMessage();
> assertTrue("Should have seen an exception because two cores had the same name",
> message.indexOf("Core core1 defined more than once") != -1);
> - assertTrue("/core1 should have been mentioned in the message", message.indexOf("/core1") != -1);
> - assertTrue("/core2 should have been mentioned in the message", message.indexOf("/core2") != -1);
> + assertTrue(File.separator + "core1 should have been mentioned in the message: " + message,
> + message.indexOf(File.separator + "core1") != -1);
> + assertTrue(File.separator + "core2 should have been mentioned in the message:" + message,
> + message.indexOf(File.separator + "core2") != -1);
> } finally {
> if (cc != null) {
> cc.shutdown();
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: svn commit: r1499074 - /lucene/dev/trunk/solr/core/src/test/org/apache/solr/core/TestCoreDiscovery.java
Posted by Alan Woodward <al...@flax.co.uk>.
Thanks both!
Alan Woodward
www.flax.co.uk
On 3 Jul 2013, at 02:47, Erick Erickson wrote:
> Cool! thanks!
>
>
> On Tue, Jul 2, 2013 at 6:12 PM, Steve Rowe <sa...@gmail.com> wrote:
> After svn up'ing trunk, TestCoreDiscovery.testDuplicateNames (and all other tests in that suite) now pass for me on Windows. - Steve
>
> On Jul 2, 2013, at 3:44 PM, erick@apache.org wrote:
>
> > Author: erick
> > Date: Tue Jul 2 19:44:46 2013
> > New Revision: 1499074
> >
> > URL: http://svn.apache.org/r1499074
> > Log:
> > Fixing another file separator issue, test only
> >
> > Modified:
> > lucene/dev/trunk/solr/core/src/test/org/apache/solr/core/TestCoreDiscovery.java
> >
> > Modified: lucene/dev/trunk/solr/core/src/test/org/apache/solr/core/TestCoreDiscovery.java
> > URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/test/org/apache/solr/core/TestCoreDiscovery.java?rev=1499074&r1=1499073&r2=1499074&view=diff
> > ==============================================================================
> > --- lucene/dev/trunk/solr/core/src/test/org/apache/solr/core/TestCoreDiscovery.java (original)
> > +++ lucene/dev/trunk/solr/core/src/test/org/apache/solr/core/TestCoreDiscovery.java Tue Jul 2 19:44:46 2013
> > @@ -184,8 +184,10 @@ public class TestCoreDiscovery extends S
> > String message = cause.getMessage();
> > assertTrue("Should have seen an exception because two cores had the same name",
> > message.indexOf("Core core1 defined more than once") != -1);
> > - assertTrue("/core1 should have been mentioned in the message", message.indexOf("/core1") != -1);
> > - assertTrue("/core2 should have been mentioned in the message", message.indexOf("/core2") != -1);
> > + assertTrue(File.separator + "core1 should have been mentioned in the message: " + message,
> > + message.indexOf(File.separator + "core1") != -1);
> > + assertTrue(File.separator + "core2 should have been mentioned in the message:" + message,
> > + message.indexOf(File.separator + "core2") != -1);
> > } finally {
> > if (cc != null) {
> > cc.shutdown();
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>
Re: svn commit: r1499074 - /lucene/dev/trunk/solr/core/src/test/org/apache/solr/core/TestCoreDiscovery.java
Posted by Erick Erickson <er...@gmail.com>.
Cool! thanks!
On Tue, Jul 2, 2013 at 6:12 PM, Steve Rowe <sa...@gmail.com> wrote:
> After svn up'ing trunk, TestCoreDiscovery.testDuplicateNames (and all
> other tests in that suite) now pass for me on Windows. - Steve
>
> On Jul 2, 2013, at 3:44 PM, erick@apache.org wrote:
>
> > Author: erick
> > Date: Tue Jul 2 19:44:46 2013
> > New Revision: 1499074
> >
> > URL: http://svn.apache.org/r1499074
> > Log:
> > Fixing another file separator issue, test only
> >
> > Modified:
> >
> lucene/dev/trunk/solr/core/src/test/org/apache/solr/core/TestCoreDiscovery.java
> >
> > Modified:
> lucene/dev/trunk/solr/core/src/test/org/apache/solr/core/TestCoreDiscovery.java
> > URL:
> http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/test/org/apache/solr/core/TestCoreDiscovery.java?rev=1499074&r1=1499073&r2=1499074&view=diff
> >
> ==============================================================================
> > ---
> lucene/dev/trunk/solr/core/src/test/org/apache/solr/core/TestCoreDiscovery.java
> (original)
> > +++
> lucene/dev/trunk/solr/core/src/test/org/apache/solr/core/TestCoreDiscovery.java
> Tue Jul 2 19:44:46 2013
> > @@ -184,8 +184,10 @@ public class TestCoreDiscovery extends S
> > String message = cause.getMessage();
> > assertTrue("Should have seen an exception because two cores had
> the same name",
> > message.indexOf("Core core1 defined more than once") != -1);
> > - assertTrue("/core1 should have been mentioned in the message",
> message.indexOf("/core1") != -1);
> > - assertTrue("/core2 should have been mentioned in the message",
> message.indexOf("/core2") != -1);
> > + assertTrue(File.separator + "core1 should have been mentioned in
> the message: " + message,
> > + message.indexOf(File.separator + "core1") != -1);
> > + assertTrue(File.separator + "core2 should have been mentioned in
> the message:" + message,
> > + message.indexOf(File.separator + "core2") != -1);
> > } finally {
> > if (cc != null) {
> > cc.shutdown();
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>