[GitHub] [inlong] yunqingmoswu commented on a diff in pull request #6793: [INLONG-6792][Sort] Supports dirty data side-output for hbase sink

[GitBox <gi...@apache.org>]

yunqingmoswu commented on code in PR #6793:
URL: https://github.com/apache/inlong/pull/6793#discussion_r1044074024


##########
inlong-sort/sort-core/src/test/java/org/apache/inlong/sort/parser/HbaseLoadFlinkSqlParseTest.java:
##########
@@ -71,14 +72,21 @@ private MySqlExtractNode buildMySQLExtractNode() {
      * @return hbase load node
      */
     private HbaseLoadNode buildHbaseLoadNode() {
+        Map<String, String> properties = new LinkedHashMap<>();
+        properties.put("dirty.side-output.connector", "log");
+        properties.put("dirty.ignore", "true");
+        properties.put("dirty.side-output.enable", "true");
+        properties.put("dirty.side-output.format", "csv");
+        properties.put("dirty.side-output.labels",
+                "SYSTEM_TIME=${SYSTEM_TIME}&DIRTY_TYPE=${DIRTY_TYPE}&database=inlong&table=inlong_iceberg");

Review Comment:
   done



##########
inlong-sort/sort-connectors/hbase/src/main/java/org/apache/inlong/sort/hbase/sink/HBaseSinkFunction.java:
##########
@@ -133,11 +144,13 @@ public HBaseSinkFunction(
         this.bufferFlushIntervalMillis = bufferFlushIntervalMillis;
         this.inlongMetric = inlongMetric;
         this.inlongAudit = inlongAudit;
+        this.dirtyOptions = dirtyOptions;
+        this.dirtySink = dirtySink;
     }
 
     @Override
     public void open(Configuration parameters) throws Exception {
-        LOG.info("start open ...");
+        LOGGER.info("start open ...");

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org