[jira] [Commented] (OOZIE-1801) ZKLocksService instrumentation should say how many locks this server has

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13980620#comment-13980620 ] 

Hadoop QA commented on OOZIE-1801:
----------------------------------

Testing JIRA OOZIE-1801

Cleaning local git workspace

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:green}+1{color} the patch does not introduce any line longer than 132
.    {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:green}+1 COMPILE{color}
.    {color:green}+1{color} HEAD compiles
.    {color:green}+1{color} patch compiles
.    {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.    {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
.    {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.    Tests run: 1437
.    Tests failed: 5
.    Tests errors: 5

.    The patch failed the following testcases:

.      testBundlePauseExtendMaterializesCoordinator(org.apache.oozie.command.bundle.TestBundleChangeXCommand)
.      testCoordStatusTransitServiceBackwardSupport(org.apache.oozie.service.TestStatusTransitService)
.      testBundleStatusNotTransitionFromKilled(org.apache.oozie.service.TestStatusTransitService)
.      testCoordinatorActionCommandsSubmitAndStart(org.apache.oozie.sla.TestSLAEventGeneration)
.      testCoordDefUnsupportedChange(org.apache.oozie.command.coord.TestCoordUpdateXCommand)

{color:green}+1 DISTRO{color}
.    {color:green}+1{color} distro tarball builds with the patch 

----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/1199/

> ZKLocksService instrumentation should say how many locks this server has
> ------------------------------------------------------------------------
>
>                 Key: OOZIE-1801
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1801
>             Project: Oozie
>          Issue Type: Improvement
>          Components: HA
>    Affects Versions: trunk
>            Reporter: Robert Kanter
>            Assignee: Robert Kanter
>         Attachments: OOZIE-1801.patch
>
>
> The MemoryLocksService has a variable named "locks" under the "locks" group in the instrumentation that reports how many locks are currently acquired.  When using Oozie HA, we don't have this.  
> We shouldn't have it report the total number of locks acquired by all Oozie servers because that would require checking ZooKeeper every time we check this.  However, reporting the number of locks acquired by _this_ Oozie server should be inexpensive while still being helpful and similar to the non-HA behavior.



--
This message was sent by Atlassian JIRA
(v6.2#6252)