You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Juergen Donnerstag (JIRA)" <ji...@apache.org> on 2010/11/13 13:46:14 UTC

[jira] Closed: (WICKET-701) Allow wicket filter-mapping to use servlet-name instead of url-pattern

     [ https://issues.apache.org/jira/browse/WICKET-701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Juergen Donnerstag closed WICKET-701.
-------------------------------------

    Resolution: Fixed
      Assignee: Juergen Donnerstag

seems to be fixed in 1.5. See WicketSessionFilter

> Allow wicket filter-mapping to use servlet-name instead of url-pattern
> ----------------------------------------------------------------------
>
>                 Key: WICKET-701
>                 URL: https://issues.apache.org/jira/browse/WICKET-701
>             Project: Wicket
>          Issue Type: New Feature
>          Components: wicket
>    Affects Versions: 1.3.1
>            Reporter: James Renfro
>            Assignee: Juergen Donnerstag
>             Fix For: 1.5-M4
>
>
> In the web.xml filter-mapping tag it's possible to map filters to either a url-pattern or a servlet-name. Currently Wicket only allows a url-pattern, and in the getFilterPath code an exception is thrown if servlet-name is used instead. 
> I'm guessing the logic was that if you're going to do a filter-mapping to a servlet then you may as well use WicketServlet. And it looks like the code needs a way to grab the underlying url-pattern -- if you implement the WicketServlet instead, wicket seems to force you to have a servlet-mapping to a url-pattern -- so getFilterPath can calculate relative paths, it looks like...  But there are cases in certain frameworks (Sakai -- www.sakaiproject.org -- is one example) where a portal is forwarding control directly to a servlet by name, and the url-pattern doesn't really make any sense. It'd be cleaner (from the point of view of my code at least) if Wicket would accept that in certain cases there is no url-pattern defined. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.