You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "wayneguow (via GitHub)" <gi...@apache.org> on 2023/02/07 12:33:20 UTC
[GitHub] [spark] wayneguow opened a new pull request, #39906: [SPARK-41962][MINOR][SQL] Update the order of imports in class SpecificParquetRecordReaderBase
wayneguow opened a new pull request, #39906:
URL: https://github.com/apache/spark/pull/39906
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Update the order of imports in class SpecificParquetRecordReaderBase.
### Why are the changes needed?
Follow the code style.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Passed GA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #39906: [SPARK-41962][MINOR][SQL] Update the order of imports in class SpecificParquetRecordReaderBase
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #39906:
URL: https://github.com/apache/spark/pull/39906#issuecomment-1423266159
Hi, @wayneguow and @HyukjinKwon This broke branch-3.2.
- https://github.com/apache/spark/commits/branch-3.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #39906: [SPARK-41962][MINOR][SQL] Update the order of imports in class SpecificParquetRecordReaderBase
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #39906:
URL: https://github.com/apache/spark/pull/39906#issuecomment-1423293234
Thank you for the confirmation, @wayneguow .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #39906: [SPARK-41962][MINOR][SQL] Update the order of imports in class SpecificParquetRecordReaderBase
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #39906:
URL: https://github.com/apache/spark/pull/39906#issuecomment-1423274262
You can make a new backporting PR to branch-3.2 if needed, @wayneguow .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wayneguow commented on a diff in pull request #39906: [WIP][SPARK-41962][MINOR][SQL] Update the order of imports in class SpecificParquetRecordReaderBase
Posted by "wayneguow (via GitHub)" <gi...@apache.org>.
wayneguow commented on code in PR #39906:
URL: https://github.com/apache/spark/pull/39906#discussion_r1098177487
##########
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java:
##########
@@ -28,12 +28,9 @@
import java.util.Map;
import java.util.Set;
-import com.google.common.annotations.VisibleForTesting;
-import org.apache.parquet.VersionParser;
-import org.apache.parquet.VersionParser.ParsedVersion;
-import org.apache.parquet.column.page.PageReadStore;
Review Comment:
After pr #35945 and discussion in pr #35970, the `ImportOrder` todo has been removed, the conclusion is that it's not worth changing all unordered files.
So shall we just make a little change for closing the related issued opened by uses?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #39906: [SPARK-41962][MINOR][SQL] Update the order of imports in class SpecificParquetRecordReaderBase
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #39906:
URL: https://github.com/apache/spark/pull/39906#issuecomment-1420297449
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wayneguow commented on pull request #39906: [SPARK-41962][MINOR][SQL] Update the order of imports in class SpecificParquetRecordReaderBase
Posted by "wayneguow (via GitHub)" <gi...@apache.org>.
wayneguow commented on PR #39906:
URL: https://github.com/apache/spark/pull/39906#issuecomment-1423272897
> I reverted the commit from `branch-3.2` because the `import` statement is unused.
>
> * [c8b47ec](https://github.com/apache/spark/commit/c8b47ec2d0a066f539a98488502fce99efe006f0)
>
> 
@dongjoon-hyun Thank you for resolving it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #39906: [SPARK-41962][MINOR][SQL] Update the order of imports in class SpecificParquetRecordReaderBase
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #39906:
URL: https://github.com/apache/spark/pull/39906#discussion_r1097444982
##########
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java:
##########
@@ -28,12 +28,9 @@
import java.util.Map;
import java.util.Set;
-import com.google.common.annotations.VisibleForTesting;
-import org.apache.parquet.VersionParser;
-import org.apache.parquet.VersionParser.ParsedVersion;
-import org.apache.parquet.column.page.PageReadStore;
Review Comment:
Can we fix `dev/checkstyle.xml` to enforce this order?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wayneguow commented on a diff in pull request #39906: [SPARK-41962][MINOR][SQL] Update the order of imports in class SpecificParquetRecordReaderBase
Posted by "wayneguow (via GitHub)" <gi...@apache.org>.
wayneguow commented on code in PR #39906:
URL: https://github.com/apache/spark/pull/39906#discussion_r1097455456
##########
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java:
##########
@@ -28,12 +28,9 @@
import java.util.Map;
import java.util.Set;
-import com.google.common.annotations.VisibleForTesting;
-import org.apache.parquet.VersionParser;
-import org.apache.parquet.VersionParser.ParsedVersion;
-import org.apache.parquet.column.page.PageReadStore;
Review Comment:
Ok, that's better, and once and for all. I'll make some changes later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wayneguow commented on pull request #39906: [SPARK-41962][MINOR][SQL] Update the order of imports in class SpecificParquetRecordReaderBase
Posted by "wayneguow (via GitHub)" <gi...@apache.org>.
wayneguow commented on PR #39906:
URL: https://github.com/apache/spark/pull/39906#issuecomment-1423286391
> You can make a new backporting PR to branch-3.2 if needed, @wayneguow .
<img width="475" alt="image" src="https://user-images.githubusercontent.com/16032294/217658729-c709f636-1c3a-429b-b7e8-9929961eba49.png">
It seems that it is ok without those unordered imports in branch-3.2, so just reverting this for branch-3.2 is enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #39906: [SPARK-41962][MINOR][SQL] Update the order of imports in class SpecificParquetRecordReaderBase
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #39906: [SPARK-41962][MINOR][SQL] Update the order of imports in class SpecificParquetRecordReaderBase
URL: https://github.com/apache/spark/pull/39906
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #39906: [SPARK-41962][MINOR][SQL] Update the order of imports in class SpecificParquetRecordReaderBase
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #39906:
URL: https://github.com/apache/spark/pull/39906#issuecomment-1420700025
no need to take this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #39906: [SPARK-41962][MINOR][SQL] Update the order of imports in class SpecificParquetRecordReaderBase
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #39906:
URL: https://github.com/apache/spark/pull/39906#issuecomment-1423268335
I reverted the commit because the `import` statement is unused.
- https://github.com/apache/spark/commit/c8b47ec2d0a066f539a98488502fce99efe006f0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #39906: [SPARK-41962][MINOR][SQL] Update the order of imports in class SpecificParquetRecordReaderBase
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #39906:
URL: https://github.com/apache/spark/pull/39906#issuecomment-1423275269
Also, cc @parthchandra for branch-3.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #39906: [SPARK-41962][MINOR][SQL] Update the order of imports in class SpecificParquetRecordReaderBase
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #39906: [SPARK-41962][MINOR][SQL] Update the order of imports in class SpecificParquetRecordReaderBase
URL: https://github.com/apache/spark/pull/39906
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org