You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/06/12 18:33:29 UTC
[GitHub] [commons-lang] shalk opened a new pull request, #912: update ClassUtils javadoc with some missing throws NPE
shalk opened a new pull request, #912:
URL: https://github.com/apache/commons-lang/pull/912
method `toCanonicalName` use method Validate.notNull , so it could throw npe.
meanswhile `getClass` use mehtod `toCanonicalName`, so these method also throw npe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] shalk commented on pull request #912: update ClassUtils javadoc with some missing throws NPE
Posted by GitBox <gi...@apache.org>.
shalk commented on PR #912:
URL: https://github.com/apache/commons-lang/pull/912#issuecomment-1154103934
>
I found some apis return null if argument is null and the other apis check them throw npe. they are different behave for argument.
For example, `ClassUtils.getAllInterfaces` document ` {@code null} if null input` , so i think append `ClassUtils.getClass` with `@throws NullPointerException if the className is null` is meaningful.
I aslo found ClassUtilsTest have cover the npe case. So document can also cover it and these document will not break code.
May be we should check which kind of npe should declare in document.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #912: update ClassUtils javadoc with some missing throws NPE
Posted by GitBox <gi...@apache.org>.
garydgregory commented on PR #912:
URL: https://github.com/apache/commons-lang/pull/912#issuecomment-1153965906
I'm not 100% sure we want to go down this road because most APIs can throw NPEs... Are we going to go over the whole library and do this? WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] kinow commented on pull request #912: update ClassUtils javadoc with some missing throws NPE
Posted by GitBox <gi...@apache.org>.
kinow commented on PR #912:
URL: https://github.com/apache/commons-lang/pull/912#issuecomment-1154429965
When reviewing this I also looked at other methods and found some documenting the behavior about null's and illegal argument/other runtime exceptions. But not sure if we want to document every case or not :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] codecov-commenter commented on pull request #912: update ClassUtils javadoc with some missing throws NPE
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #912:
URL: https://github.com/apache/commons-lang/pull/912#issuecomment-1153261014
# [Codecov](https://codecov.io/gh/apache/commons-lang/pull/912?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#912](https://codecov.io/gh/apache/commons-lang/pull/912?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3816de2) into [master](https://codecov.io/gh/apache/commons-lang/commit/ef07c645efe7a490f21ae80473814d6117832ded?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ef07c64) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #912 +/- ##
=========================================
Coverage 91.73% 91.73%
Complexity 7437 7437
=========================================
Files 188 188
Lines 15953 15953
Branches 2999 2999
=========================================
Hits 14634 14634
Misses 726 726
Partials 593 593
```
| [Impacted Files](https://codecov.io/gh/apache/commons-lang/pull/912?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/commons/lang3/ClassUtils.java](https://codecov.io/gh/apache/commons-lang/pull/912/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvQ2xhc3NVdGlscy5qYXZh) | `90.70% <ø> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/commons-lang/pull/912?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/commons-lang/pull/912?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ef07c64...3816de2](https://codecov.io/gh/apache/commons-lang/pull/912?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory merged pull request #912: Update ClassUtils Javadoc with some missing throws NPE
Posted by GitBox <gi...@apache.org>.
garydgregory merged PR #912:
URL: https://github.com/apache/commons-lang/pull/912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org