You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org> on 2017/02/10 19:00:06 UTC
Change in asterixdb[master]: Report integer metrics as numbers
Till Westmann has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/1496
Change subject: Report integer metrics as numbers
......................................................................
Report integer metrics as numbers
Change-Id: Ie330ba0e030d188adbf675741c382cf2754853f1
---
M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
1 file changed, 11 insertions(+), 4 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/96/1496/1
diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
index 744b929..7cb492b 100644
--- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
+++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
@@ -337,11 +337,18 @@
}
private static void printField(PrintWriter pw, String name, String value, boolean comma) {
+ printFieldInternal(pw, name, "\"" + value + "\"", comma);
+ }
+
+ private static void printField(PrintWriter pw, String name, long value, boolean comma) {
+ printFieldInternal(pw, name, String.valueOf(value), comma);
+ }
+
+ private static void printFieldInternal(PrintWriter pw, String name, String value, boolean comma) {
pw.print("\t\"");
pw.print(name);
- pw.print("\": \"");
+ pw.print("\": ");
pw.print(value);
- pw.print('"');
if (comma) {
pw.print(',');
}
@@ -409,9 +416,9 @@
pw.print("\t");
printField(pw, Metrics.EXECUTION_TIME.str(), TimeUnit.formatNanos(executionTime));
pw.print("\t");
- printField(pw, Metrics.RESULT_COUNT.str(), String.valueOf(resultCount));
+ printField(pw, Metrics.RESULT_COUNT.str(), resultCount, true);
pw.print("\t");
- printField(pw, Metrics.RESULT_SIZE.str(), String.valueOf(resultSize), false);
+ printField(pw, Metrics.RESULT_SIZE.str(), resultSize, false);
pw.print("\t}\n");
}
--
To view, visit https://asterix-gerrit.ics.uci.edu/1496
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie330ba0e030d188adbf675741c382cf2754853f1
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Change in asterixdb[master]: Report integer metrics as numbers
Posted by "Ian Maxon (Code Review)" <do...@asterixdb.incubator.apache.org>.
Ian Maxon has posted comments on this change.
Change subject: Report integer metrics as numbers
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://asterix-gerrit.ics.uci.edu/1496
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie330ba0e030d188adbf675741c382cf2754853f1
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: Report integer metrics as numbers
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Report integer metrics as numbers
......................................................................
Patch Set 1: BAD-1
BAD Compatibility Tests Failed
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/513/ : FAILURE
--
To view, visit https://asterix-gerrit.ics.uci.edu/1496
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie330ba0e030d188adbf675741c382cf2754853f1
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: Report integer metrics as numbers
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Report integer metrics as numbers
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4245/
--
To view, visit https://asterix-gerrit.ics.uci.edu/1496
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie330ba0e030d188adbf675741c382cf2754853f1
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: Report integer metrics as numbers
Posted by "Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org>.
Till Westmann has submitted this change and it was merged.
Change subject: Report integer metrics as numbers
......................................................................
Report integer metrics as numbers
Change-Id: Ie330ba0e030d188adbf675741c382cf2754853f1
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1496
Sonar-Qube: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Ian Maxon <im...@apache.org>
---
M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
1 file changed, 11 insertions(+), 4 deletions(-)
Approvals:
Ian Maxon: Looks good to me, approved
Jenkins: Verified; No violations found; Verified
Objections:
Jenkins: Violations found
diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
index 744b929..7cb492b 100644
--- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
+++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
@@ -337,11 +337,18 @@
}
private static void printField(PrintWriter pw, String name, String value, boolean comma) {
+ printFieldInternal(pw, name, "\"" + value + "\"", comma);
+ }
+
+ private static void printField(PrintWriter pw, String name, long value, boolean comma) {
+ printFieldInternal(pw, name, String.valueOf(value), comma);
+ }
+
+ private static void printFieldInternal(PrintWriter pw, String name, String value, boolean comma) {
pw.print("\t\"");
pw.print(name);
- pw.print("\": \"");
+ pw.print("\": ");
pw.print(value);
- pw.print('"');
if (comma) {
pw.print(',');
}
@@ -409,9 +416,9 @@
pw.print("\t");
printField(pw, Metrics.EXECUTION_TIME.str(), TimeUnit.formatNanos(executionTime));
pw.print("\t");
- printField(pw, Metrics.RESULT_COUNT.str(), String.valueOf(resultCount));
+ printField(pw, Metrics.RESULT_COUNT.str(), resultCount, true);
pw.print("\t");
- printField(pw, Metrics.RESULT_SIZE.str(), String.valueOf(resultSize), false);
+ printField(pw, Metrics.RESULT_SIZE.str(), resultSize, false);
pw.print("\t}\n");
}
--
To view, visit https://asterix-gerrit.ics.uci.edu/1496
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie330ba0e030d188adbf675741c382cf2754853f1
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Change in asterixdb[master]: Report integer metrics as numbers
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Report integer metrics as numbers
......................................................................
Patch Set 1: Integration-Tests+1
Integration Tests Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1861/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/1496
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie330ba0e030d188adbf675741c382cf2754853f1
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: Report integer metrics as numbers
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Report integer metrics as numbers
......................................................................
Patch Set 1: Integration-Tests-1
Integration Tests Failed
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1854/ : UNSTABLE
--
To view, visit https://asterix-gerrit.ics.uci.edu/1496
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie330ba0e030d188adbf675741c382cf2754853f1
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: Report integer metrics as numbers
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Report integer metrics as numbers
......................................................................
Patch Set 1:
BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/513/
--
To view, visit https://asterix-gerrit.ics.uci.edu/1496
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie330ba0e030d188adbf675741c382cf2754853f1
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: Report integer metrics as numbers
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Report integer metrics as numbers
......................................................................
Patch Set 1:
Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1854/
--
To view, visit https://asterix-gerrit.ics.uci.edu/1496
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie330ba0e030d188adbf675741c382cf2754853f1
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: Report integer metrics as numbers
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Report integer metrics as numbers
......................................................................
Patch Set 1:
Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1861/
--
To view, visit https://asterix-gerrit.ics.uci.edu/1496
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie330ba0e030d188adbf675741c382cf2754853f1
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-HasComments: No