You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Giovanni Fernandez-Kincade (JIRA)" <ji...@apache.org> on 2011/04/07 21:50:05 UTC
[jira] [Created] (SOLR-2461) Make QuerySenderListener Public
Make QuerySenderListener Public
-------------------------------
Key: SOLR-2461
URL: https://issues.apache.org/jira/browse/SOLR-2461
Project: Solr
Issue Type: Improvement
Reporter: Giovanni Fernandez-Kincade
Priority: Minor
There are legitimate use-cases for folks to extend QuerySenderListener. For example, at Etsy, we would like toggle warm-up queries according to feature flags in our business logic. Unfortunately, this class is declared with the default access level...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (SOLR-2461) Make QuerySenderListener Public
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hoss Man resolved SOLR-2461.
----------------------------
Resolution: Fixed
Fix Version/s: 4.0
Assignee: Hoss Man
Yeah, i'm not sure that there is any reason why QuerySenderListener and AbstractSolrEventListener were never made public.
i don't see that there is much extinsible value add beyond the "if (condition) super.method(...)" style delegation, but as you mention: even that has it's advantages.
if you have other suggestiosn for refactoring the class to be more useful when extending, please feel free to open other issues (and submit patches)
Committed revision 1095545.
> Make QuerySenderListener Public
> -------------------------------
>
> Key: SOLR-2461
> URL: https://issues.apache.org/jira/browse/SOLR-2461
> Project: Solr
> Issue Type: Improvement
> Reporter: Giovanni Fernandez-Kincade
> Assignee: Hoss Man
> Priority: Minor
> Fix For: 4.0
>
>
> There are legitimate use-cases for folks to extend QuerySenderListener. For example, at Etsy, we would like toggle warm-up queries according to feature flags in our business logic. Unfortunately, this class is declared with the default access level...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org