[jira] [Resolved] (FELIX-5980) Maven Bundle Plugin Regression: incorrect filtering

["Guillaume Nodet (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FELIX-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Guillaume Nodet resolved FELIX-5980.
------------------------------------
      Assignee: Guillaume Nodet
    Resolution: Cannot Reproduce

I've tried to reproduce the issue but was unsuccessful.  The project you've attached works fine for me, whatever version of the maven bundle plugin I configure.

I suspect this is not related to the maven-bundle-plugin, as it is not supposed to modify resources at all.

> Maven Bundle Plugin Regression: incorrect filtering
> ---------------------------------------------------
>
>                 Key: FELIX-5980
>                 URL: https://issues.apache.org/jira/browse/FELIX-5980
>             Project: Felix
>          Issue Type: Bug
>          Components: Maven Bundle Plugin
>    Affects Versions: maven-bundle-plugin-4.1.0
>            Reporter: Florian Brunner
>            Assignee: Guillaume Nodet
>            Priority: Critical
>         Attachments: bundle-plugin-filtering-issue.tar.gz
>
>
> With Maven resource filtering enabled, the following Maven Bunde Plugin configuration
> {code:java}
>              <plugin>
>                 <groupId>org.apache.felix</groupId>
>                 <artifactId>maven-bundle-plugin</artifactId>
>                 <extensions>true</extensions>  
>                 <configuration>
>                     <versions>
>                         <module-a.osgi.version.clean>${project.version}</module-a.osgi.version.clean>
>                     </versions>
>                 </configuration>
>                 <executions>
>                     <execution>
>                         <phase>generate-sources</phase>
>                         <goals>
>                             <goal>cleanVersions</goal>
>                         </goals>
>                     </execution>
>                 </executions>     
>             </plugin>
> {code}
> filters the following file:
> {code:java}
> org.osgi.framework.system.packages.extra=${module-a.packages}
> module-a.packages=${module-b.packages}, \
> issue.bundleplugin.filtering;version="${module-a.osgi.version.clean}", \
> ${foo-${foo.specification.version}}
> foo-1=org.foo
> {code}
> correctly to target/classes:
> {code:java}
> org.osgi.framework.system.packages.extra=${module-a.packages}
> module-a.packages=${module-b.packages}, \
> issue.bundleplugin.filtering;version="0.1.0.SNAPSHOT", \
> ${foo-${foo.specification.version}}
> foo-1=org.foo{code}
> but the bundle goal then adds the following properties file to the bundle JAR:
> {code:java}
> org.osgi.framework.system.packages.extra=${module-a.packages}
> module-a.packages=${module-b.packages}, \
> issue.bundleplugin.filtering;version="0.1.0.SNAPSHOT", \
> foo-1=org.foo
> {code}
> ${foo-${foo.specification.version}} got stripped to empty string!
> Affected version: 4.1.0
> It used to work with version 3.5.0 -> regression
> I see two issues:
>  # ${foo-${foo.specification.version}} got stripped to empty string
>  # The bunde goal should just be about packaging. It should not change files from target/classes at all.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)