[GitHub] [hive] miklosgergely commented on a change in pull request #2007: HIVE-24811: Extend Cached Dates to Other Areas

[GitBox <gi...@apache.org>]

miklosgergely commented on a change in pull request #2007:
URL: https://github.com/apache/hive/pull/2007#discussion_r582340030



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateDiff.java
##########
@@ -110,17 +111,18 @@ private Date convertToDate(PrimitiveCategory inputType, Converter converter, Def
     switch (inputType) {
     case STRING:
     case VARCHAR:
-    case CHAR:
+    case CHAR: {

Review comment:
       Why the barces? We don't use them anywhere else, no need for them, in a switch the code after a case is a block by default.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org