You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by pa...@apache.org on 2020/02/04 20:11:49 UTC

[wicket] branch csp updated: WICKET-6738: replaced inline styling with classes

This is an automated email from the ASF dual-hosted git repository.

papegaaij pushed a commit to branch csp
in repository https://gitbox.apache.org/repos/asf/wicket.git


The following commit(s) were added to refs/heads/csp by this push:
     new fac12c9  WICKET-6738: replaced inline styling with classes
fac12c9 is described below

commit fac12c948a36ac0cdd42b263c1ba57e5159851e0
Author: Emond Papegaaij <em...@topicus.nl>
AuthorDate: Tue Feb 4 21:11:29 2020 +0100

    WICKET-6738: replaced inline styling with classes
---
 .../ajax/markup/html/form/upload/UploadProgressBar.html        |  4 ++--
 .../extensions/ajax/markup/html/form/upload/progressbar.js     | 10 +++++-----
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/UploadProgressBar.html b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/UploadProgressBar.html
index 4572293..e679353 100644
--- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/UploadProgressBar.html
+++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/UploadProgressBar.html
@@ -17,7 +17,7 @@
 -->
 <wicket:panel xmlns:wicket="http://wicket.apache.org">
     <div class="wupb-container">
-        <div class="wupb-progressBar" wicket:id="bar" style="display:none;"><div class="wupb-border"><div class="wupb-background"><div class="wupb-foreground"></div></div></div></div>
-        <div class="wupb-uploadStatus" wicket:id="status" style="display:none;"></div>
+        <div class="wupb-progressBar wicket--hidden" wicket:id="bar"><div class="wupb-border"><div class="wupb-background"><div class="wupb-foreground"></div></div></div></div>
+        <div class="wupb-uploadStatus wicket--hidden" wicket:id="status"></div>
     </div>
 </wicket:panel>
\ No newline at end of file
diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/progressbar.js b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/progressbar.js
index bf43d52..e2265bd 100644
--- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/progressbar.js
+++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/progressbar.js
@@ -55,8 +55,8 @@
 			if (displayprogress) {
 				this.setPercent(0);
 				this.setStatus(this.initialStatus);
-				Wicket.DOM.show(this.statusid, 'block');
-				Wicket.DOM.show(this.barid, 'block');
+				Wicket.DOM.toggleClass(this.statusid, 'wicket--hidden', false);
+				Wicket.DOM.toggleClass(this.barid, 'wicket--hidden', false);
 				this.scheduleUpdate();
 			}
 		},
@@ -81,7 +81,7 @@
 
 		_createIFrame : function (iframeName) {
 			var $iframe = jQuery('<iframe name="'+iframeName+'" id="'+iframeName+
-				'" src="about:blank" style="position: absolute; top: -9999px; left: -9999px;"></iframe>');
+				'" src="about:blank" class="wicket--hidden-fields"></iframe>');
 			return $iframe[0];
 		},
 
@@ -117,8 +117,8 @@
 			this.iframe = null;
 
 			if (progressPercent === '100') {
-				Wicket.DOM.hide(this.statusid);
-				Wicket.DOM.hide(this.barid);
+				Wicket.DOM.toggleClass(this.statusid, 'wicket--hidden', true);
+				Wicket.DOM.toggleClass(this.barid, 'wicket--hidden', true);
 			} else {
 				this.scheduleUpdate();
 			}