You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "Eugene Kirpichov (JIRA)" <ji...@apache.org> on 2017/03/01 02:28:46 UTC

[jira] [Created] (BEAM-1578) Runners should put PT overrides into a list rather than map

Eugene Kirpichov created BEAM-1578:
--------------------------------------

             Summary: Runners should put PT overrides into a list rather than map
                 Key: BEAM-1578
                 URL: https://issues.apache.org/jira/browse/BEAM-1578
             Project: Beam
          Issue Type: Bug
          Components: runner-dataflow, runner-direct
            Reporter: Eugene Kirpichov
            Assignee: Eugene Kirpichov
            Priority: Minor


It was not clear to me from the code that order of overrides is important. Map is not the best data structure for this, especially since no key lookups happen.

Referring to
https://github.com/apache/beam/blob/master/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
and
https://github.com/apache/beam/blob/master/runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectRunner.java
and possibly others.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)