You are viewing a plain text version of this content. The canonical link for it is here.
Posted to surefire-commits@maven.apache.org by da...@apache.org on 2009/01/04 12:11:34 UTC

svn commit: r731220 - /maven/surefire/trunk/maven-surefire-plugin/src/main/java/org/apache/maven/plugin/surefire/SurefirePlugin.java

Author: dantran
Date: Sun Jan  4 03:11:33 2009
New Revision: 731220

URL: http://svn.apache.org/viewvc?rev=731220&view=rev
Log:
SUREFIRE-511: allow null systemPropertyVariable's value, otherwise user cannot migrate deprecated systemProperties. Forgot one check-in from the last commit

Modified:
    maven/surefire/trunk/maven-surefire-plugin/src/main/java/org/apache/maven/plugin/surefire/SurefirePlugin.java

Modified: maven/surefire/trunk/maven-surefire-plugin/src/main/java/org/apache/maven/plugin/surefire/SurefirePlugin.java
URL: http://svn.apache.org/viewvc/maven/surefire/trunk/maven-surefire-plugin/src/main/java/org/apache/maven/plugin/surefire/SurefirePlugin.java?rev=731220&r1=731219&r2=731220&view=diff
==============================================================================
--- maven/surefire/trunk/maven-surefire-plugin/src/main/java/org/apache/maven/plugin/surefire/SurefirePlugin.java (original)
+++ maven/surefire/trunk/maven-surefire-plugin/src/main/java/org/apache/maven/plugin/surefire/SurefirePlugin.java Sun Jan  4 03:11:33 2009
@@ -1040,13 +1040,12 @@
             {
                 String key = (String) i.next();
                 String value = (String) systemPropertyVariables.get( key );
-                if ( value == null )
+                //java Properties does not accept null value
+                if ( value != null )
                 {
-                    this.getLog().error( key + "'s value cannot be null." );
+                    internalSystemProperties.setProperty( key, value );
                 }
-                internalSystemProperties.setProperty( key, value );
             }
-            
         }
 
         originalSystemProperties = (Properties) System.getProperties().clone();