You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by Josh Elser <el...@apache.org> on 2017/05/05 23:24:05 UTC
[VOTE] Merge space quota branch (HBASE-16961) into master
Folks,
This is a vote to (rebase and) merge the branch HBASE-16961 into master.
Per the book, this requires 3 binding +1's from other committers to merge.
Relevant info for those who want to revisit any topics:
DISCUSS on merge[1]
Design Doc[2]
Staged user manual[3]
I'll plan to leave this open for at least 72hrs of the work days
(Wednesday May 10th EOD) in case there are any vetos. I would prefer to
abstain from voting on my own feature and plan to do so if the votes are
otherwise lacking.
- Josh
[1]
https://lists.apache.org/thread.html/a28c69bff315a791b9f7b946636446a60bd2ddc8d5a9f5c11c2bf6f4@%3Cdev.hbase.apache.org%3E
[2] http://home.apache.org/~elserj/hbase/FileSystemQuotasforApacheHBase.pdf
[3] https://people.apache.org/~elserj/hbase/quotas/book.html#space-quotas
Re: [VOTE] Merge space quota branch (HBASE-16961) into master
Posted by Ted Yu <yu...@gmail.com>.
+1 on merging this to master branch.
I have reviewed Josh's work for phase 1.
This is an important addition for multi-tenant deployments.
On Fri, May 5, 2017 at 4:24 PM, Josh Elser <el...@apache.org> wrote:
> Folks,
>
> This is a vote to (rebase and) merge the branch HBASE-16961 into master.
> Per the book, this requires 3 binding +1's from other committers to merge.
>
> Relevant info for those who want to revisit any topics:
>
> DISCUSS on merge[1]
> Design Doc[2]
> Staged user manual[3]
>
> I'll plan to leave this open for at least 72hrs of the work days
> (Wednesday May 10th EOD) in case there are any vetos. I would prefer to
> abstain from voting on my own feature and plan to do so if the votes are
> otherwise lacking.
>
> - Josh
>
> [1] https://lists.apache.org/thread.html/a28c69bff315a791b9f7b94
> 6636446a60bd2ddc8d5a9f5c11c2bf6f4@%3Cdev.hbase.apache.org%3E
> [2] http://home.apache.org/~elserj/hbase/FileSystemQuotasforApac
> heHBase.pdf
> [3] https://people.apache.org/~elserj/hbase/quotas/book.html#space-quotas
>
Re: [VOTE] Merge space quota branch (HBASE-16961) into master
Posted by Andrew Purtell <ap...@apache.org>.
I mentioned 2.0 if the thought of merging a major change while trying to
stabilize for branching of branch-2 was causing people to hold off casting
a vote. Maybe that is only a concern of mine.
On Tue, May 9, 2017 at 3:29 PM, Josh Elser <el...@apache.org> wrote:
> I won't pretend to be involved enough in the 2.0 work to give an opinion
> :) -- I did say earlier that I'm happy to land this in 2.0 or 3.0 (whatever
> master decides to be at the time I merge).
>
> If the spirit of the voters is to include this in 3.0 and not 2.0, that's
> fine by me. I'm also happy to not immediately merge after this vote
> completes.
>
> Andrew Purtell wrote:
>
>> Would it help to cut a branch for 2.0 before attempting to merge in a new
>> major feature?
>>
>>
>> On Tue, May 9, 2017 at 8:41 AM, Josh Elser<el...@apache.org> wrote:
>>
>> Reminder: I hope to close this in ~30hrs and there have been no votes so
>>> far.
>>>
>>>
>>> Josh Elser wrote:
>>>
>>> Folks,
>>>>
>>>> This is a vote to (rebase and) merge the branch HBASE-16961 into master.
>>>> Per the book, this requires 3 binding +1's from other committers to
>>>> merge.
>>>>
>>>> Relevant info for those who want to revisit any topics:
>>>>
>>>> DISCUSS on merge[1]
>>>> Design Doc[2]
>>>> Staged user manual[3]
>>>>
>>>> I'll plan to leave this open for at least 72hrs of the work days
>>>> (Wednesday May 10th EOD) in case there are any vetos. I would prefer to
>>>> abstain from voting on my own feature and plan to do so if the votes are
>>>> otherwise lacking.
>>>>
>>>> - Josh
>>>>
>>>> [1]
>>>> https://lists.apache.org/thread.html/a28c69bff315a791b9f7b94
>>>> 6636446a60bd2ddc8d5a9f5c11c2bf6f4@%3Cdev.hbase.apache.org%3E
>>>>
>>>> [2] http://home.apache.org/~elserj/hbase/FileSystemQuotasforApac
>>>> heHBase.pdf
>>>> [3] https://people.apache.org/~elserj/hbase/quotas/book.html#spa
>>>> ce-quotas
>>>>
>>>>
>>
>>
--
Best regards,
- Andy
If you are given a choice, you believe you have acted freely. - Raymond
Teller (via Peter Watts)
Re: [VOTE] Merge space quota branch (HBASE-16961) into master
Posted by Josh Elser <el...@apache.org>.
Right. 17748 is not in the picture right now.
Happy to leave this open for more time if people would like it. Thanks
for taking a look!
Enis Söztutar wrote:
> Just to be clear, you are proposing the merge without
> https://issues.apache.org/jira/browse/HBASE-17748 in place, right?
>
> Enis
>
> On Wed, May 10, 2017 at 4:47 PM, Enis Söztutar<en...@gmail.com> wrote:
>
>> I was following the patches up to some extend, but I am not up to date on
>> the recent stuff. Let me spend some time with the newest code.
>>
>> I think we can extend the vote to give others some more time as well.
>>
>> Enis
>>
>> On Tue, May 9, 2017 at 3:29 PM, Josh Elser<el...@apache.org> wrote:
>>
>>> I won't pretend to be involved enough in the 2.0 work to give an opinion
>>> :) -- I did say earlier that I'm happy to land this in 2.0 or 3.0 (whatever
>>> master decides to be at the time I merge).
>>>
>>> If the spirit of the voters is to include this in 3.0 and not 2.0, that's
>>> fine by me. I'm also happy to not immediately merge after this vote
>>> completes.
>>>
>>>
>>> Andrew Purtell wrote:
>>>
>>>> Would it help to cut a branch for 2.0 before attempting to merge in a new
>>>> major feature?
>>>>
>>>>
>>>> On Tue, May 9, 2017 at 8:41 AM, Josh Elser<el...@apache.org> wrote:
>>>>
>>>> Reminder: I hope to close this in ~30hrs and there have been no votes so
>>>>> far.
>>>>>
>>>>>
>>>>> Josh Elser wrote:
>>>>>
>>>>> Folks,
>>>>>> This is a vote to (rebase and) merge the branch HBASE-16961 into
>>>>>> master.
>>>>>> Per the book, this requires 3 binding +1's from other committers to
>>>>>> merge.
>>>>>>
>>>>>> Relevant info for those who want to revisit any topics:
>>>>>>
>>>>>> DISCUSS on merge[1]
>>>>>> Design Doc[2]
>>>>>> Staged user manual[3]
>>>>>>
>>>>>> I'll plan to leave this open for at least 72hrs of the work days
>>>>>> (Wednesday May 10th EOD) in case there are any vetos. I would prefer to
>>>>>> abstain from voting on my own feature and plan to do so if the votes
>>>>>> are
>>>>>> otherwise lacking.
>>>>>>
>>>>>> - Josh
>>>>>>
>>>>>> [1]
>>>>>> https://lists.apache.org/thread.html/a28c69bff315a791b9f7b94
>>>>>> 6636446a60bd2ddc8d5a9f5c11c2bf6f4@%3Cdev.hbase.apache.org%3E
>>>>>>
>>>>>> [2] http://home.apache.org/~elserj/hbase/FileSystemQuotasforApac
>>>>>> heHBase.pdf
>>>>>> [3] https://people.apache.org/~elserj/hbase/quotas/book.html#spa
>>>>>> ce-quotas
>>>>>>
>>>>>>
>>>>
>
Re: [VOTE] Merge space quota branch (HBASE-16961) into master
Posted by Enis Söztutar <en...@gmail.com>.
Just to be clear, you are proposing the merge without
https://issues.apache.org/jira/browse/HBASE-17748 in place, right?
Enis
On Wed, May 10, 2017 at 4:47 PM, Enis Söztutar <en...@gmail.com> wrote:
> I was following the patches up to some extend, but I am not up to date on
> the recent stuff. Let me spend some time with the newest code.
>
> I think we can extend the vote to give others some more time as well.
>
> Enis
>
> On Tue, May 9, 2017 at 3:29 PM, Josh Elser <el...@apache.org> wrote:
>
>> I won't pretend to be involved enough in the 2.0 work to give an opinion
>> :) -- I did say earlier that I'm happy to land this in 2.0 or 3.0 (whatever
>> master decides to be at the time I merge).
>>
>> If the spirit of the voters is to include this in 3.0 and not 2.0, that's
>> fine by me. I'm also happy to not immediately merge after this vote
>> completes.
>>
>>
>> Andrew Purtell wrote:
>>
>>> Would it help to cut a branch for 2.0 before attempting to merge in a new
>>> major feature?
>>>
>>>
>>> On Tue, May 9, 2017 at 8:41 AM, Josh Elser<el...@apache.org> wrote:
>>>
>>> Reminder: I hope to close this in ~30hrs and there have been no votes so
>>>> far.
>>>>
>>>>
>>>> Josh Elser wrote:
>>>>
>>>> Folks,
>>>>>
>>>>> This is a vote to (rebase and) merge the branch HBASE-16961 into
>>>>> master.
>>>>> Per the book, this requires 3 binding +1's from other committers to
>>>>> merge.
>>>>>
>>>>> Relevant info for those who want to revisit any topics:
>>>>>
>>>>> DISCUSS on merge[1]
>>>>> Design Doc[2]
>>>>> Staged user manual[3]
>>>>>
>>>>> I'll plan to leave this open for at least 72hrs of the work days
>>>>> (Wednesday May 10th EOD) in case there are any vetos. I would prefer to
>>>>> abstain from voting on my own feature and plan to do so if the votes
>>>>> are
>>>>> otherwise lacking.
>>>>>
>>>>> - Josh
>>>>>
>>>>> [1]
>>>>> https://lists.apache.org/thread.html/a28c69bff315a791b9f7b94
>>>>> 6636446a60bd2ddc8d5a9f5c11c2bf6f4@%3Cdev.hbase.apache.org%3E
>>>>>
>>>>> [2] http://home.apache.org/~elserj/hbase/FileSystemQuotasforApac
>>>>> heHBase.pdf
>>>>> [3] https://people.apache.org/~elserj/hbase/quotas/book.html#spa
>>>>> ce-quotas
>>>>>
>>>>>
>>>
>>>
>
Re: [VOTE] Merge space quota branch (HBASE-16961) into master
Posted by Enis Söztutar <en...@gmail.com>.
I was following the patches up to some extend, but I am not up to date on
the recent stuff. Let me spend some time with the newest code.
I think we can extend the vote to give others some more time as well.
Enis
On Tue, May 9, 2017 at 3:29 PM, Josh Elser <el...@apache.org> wrote:
> I won't pretend to be involved enough in the 2.0 work to give an opinion
> :) -- I did say earlier that I'm happy to land this in 2.0 or 3.0 (whatever
> master decides to be at the time I merge).
>
> If the spirit of the voters is to include this in 3.0 and not 2.0, that's
> fine by me. I'm also happy to not immediately merge after this vote
> completes.
>
>
> Andrew Purtell wrote:
>
>> Would it help to cut a branch for 2.0 before attempting to merge in a new
>> major feature?
>>
>>
>> On Tue, May 9, 2017 at 8:41 AM, Josh Elser<el...@apache.org> wrote:
>>
>> Reminder: I hope to close this in ~30hrs and there have been no votes so
>>> far.
>>>
>>>
>>> Josh Elser wrote:
>>>
>>> Folks,
>>>>
>>>> This is a vote to (rebase and) merge the branch HBASE-16961 into master.
>>>> Per the book, this requires 3 binding +1's from other committers to
>>>> merge.
>>>>
>>>> Relevant info for those who want to revisit any topics:
>>>>
>>>> DISCUSS on merge[1]
>>>> Design Doc[2]
>>>> Staged user manual[3]
>>>>
>>>> I'll plan to leave this open for at least 72hrs of the work days
>>>> (Wednesday May 10th EOD) in case there are any vetos. I would prefer to
>>>> abstain from voting on my own feature and plan to do so if the votes are
>>>> otherwise lacking.
>>>>
>>>> - Josh
>>>>
>>>> [1]
>>>> https://lists.apache.org/thread.html/a28c69bff315a791b9f7b94
>>>> 6636446a60bd2ddc8d5a9f5c11c2bf6f4@%3Cdev.hbase.apache.org%3E
>>>>
>>>> [2] http://home.apache.org/~elserj/hbase/FileSystemQuotasforApac
>>>> heHBase.pdf
>>>> [3] https://people.apache.org/~elserj/hbase/quotas/book.html#spa
>>>> ce-quotas
>>>>
>>>>
>>
>>
Re: [VOTE] Merge space quota branch (HBASE-16961) into master
Posted by Josh Elser <el...@apache.org>.
I won't pretend to be involved enough in the 2.0 work to give an opinion
:) -- I did say earlier that I'm happy to land this in 2.0 or 3.0
(whatever master decides to be at the time I merge).
If the spirit of the voters is to include this in 3.0 and not 2.0,
that's fine by me. I'm also happy to not immediately merge after this
vote completes.
Andrew Purtell wrote:
> Would it help to cut a branch for 2.0 before attempting to merge in a new
> major feature?
>
>
> On Tue, May 9, 2017 at 8:41 AM, Josh Elser<el...@apache.org> wrote:
>
>> Reminder: I hope to close this in ~30hrs and there have been no votes so
>> far.
>>
>>
>> Josh Elser wrote:
>>
>>> Folks,
>>>
>>> This is a vote to (rebase and) merge the branch HBASE-16961 into master.
>>> Per the book, this requires 3 binding +1's from other committers to merge.
>>>
>>> Relevant info for those who want to revisit any topics:
>>>
>>> DISCUSS on merge[1]
>>> Design Doc[2]
>>> Staged user manual[3]
>>>
>>> I'll plan to leave this open for at least 72hrs of the work days
>>> (Wednesday May 10th EOD) in case there are any vetos. I would prefer to
>>> abstain from voting on my own feature and plan to do so if the votes are
>>> otherwise lacking.
>>>
>>> - Josh
>>>
>>> [1]
>>> https://lists.apache.org/thread.html/a28c69bff315a791b9f7b94
>>> 6636446a60bd2ddc8d5a9f5c11c2bf6f4@%3Cdev.hbase.apache.org%3E
>>>
>>> [2] http://home.apache.org/~elserj/hbase/FileSystemQuotasforApac
>>> heHBase.pdf
>>> [3] https://people.apache.org/~elserj/hbase/quotas/book.html#space-quotas
>>>
>
>
Re: [VOTE] Merge space quota branch (HBASE-16961) into master
Posted by Andrew Purtell <ap...@apache.org>.
Would it help to cut a branch for 2.0 before attempting to merge in a new
major feature?
On Tue, May 9, 2017 at 8:41 AM, Josh Elser <el...@apache.org> wrote:
> Reminder: I hope to close this in ~30hrs and there have been no votes so
> far.
>
>
> Josh Elser wrote:
>
>> Folks,
>>
>> This is a vote to (rebase and) merge the branch HBASE-16961 into master.
>> Per the book, this requires 3 binding +1's from other committers to merge.
>>
>> Relevant info for those who want to revisit any topics:
>>
>> DISCUSS on merge[1]
>> Design Doc[2]
>> Staged user manual[3]
>>
>> I'll plan to leave this open for at least 72hrs of the work days
>> (Wednesday May 10th EOD) in case there are any vetos. I would prefer to
>> abstain from voting on my own feature and plan to do so if the votes are
>> otherwise lacking.
>>
>> - Josh
>>
>> [1]
>> https://lists.apache.org/thread.html/a28c69bff315a791b9f7b94
>> 6636446a60bd2ddc8d5a9f5c11c2bf6f4@%3Cdev.hbase.apache.org%3E
>>
>> [2] http://home.apache.org/~elserj/hbase/FileSystemQuotasforApac
>> heHBase.pdf
>> [3] https://people.apache.org/~elserj/hbase/quotas/book.html#space-quotas
>>
>
--
Best regards,
- Andy
If you are given a choice, you believe you have acted freely. - Raymond
Teller (via Peter Watts)
Re: [VOTE] Merge space quota branch (HBASE-16961) into master
Posted by Josh Elser <el...@apache.org>.
Reminder: I hope to close this in ~30hrs and there have been no votes so
far.
Josh Elser wrote:
> Folks,
>
> This is a vote to (rebase and) merge the branch HBASE-16961 into master.
> Per the book, this requires 3 binding +1's from other committers to merge.
>
> Relevant info for those who want to revisit any topics:
>
> DISCUSS on merge[1]
> Design Doc[2]
> Staged user manual[3]
>
> I'll plan to leave this open for at least 72hrs of the work days
> (Wednesday May 10th EOD) in case there are any vetos. I would prefer to
> abstain from voting on my own feature and plan to do so if the votes are
> otherwise lacking.
>
> - Josh
>
> [1]
> https://lists.apache.org/thread.html/a28c69bff315a791b9f7b946636446a60bd2ddc8d5a9f5c11c2bf6f4@%3Cdev.hbase.apache.org%3E
>
> [2] http://home.apache.org/~elserj/hbase/FileSystemQuotasforApacheHBase.pdf
> [3] https://people.apache.org/~elserj/hbase/quotas/book.html#space-quotas
Re: [VOTE] Merge space quota branch (HBASE-16961) into master
Posted by Enis Söztutar <en...@apache.org>.
Sorry missed the deadline again, but I've spend some time with the patches
today, and I'll cast my vote as +1 for the merge.
This feature is pretty relevant to multi-tenant, bigger clusters, and is a
good complimentary to existing quotas support.
- The code is high quality, readable, pluggable and comes with a large
number of unit tests.
- Comes with shell support, Master UI, and metrics
- Documentation
Ideally, we can have this in 2.0 (even without HBASE-17748
<https://issues.apache.org/jira/browse/HBASE-17748>), because it is useable
at this point. From my reading of the code, there is no risk to
destabilizing the current code base since almost all of the code is new,
and disabled by default.
Thanks,
Enis
On Thu, May 11, 2017 at 2:50 PM, Josh Elser <el...@apache.org> wrote:
> As requested (later in this thread), I'll make sure this VOTE stays open
> at least until 2017-05-17 (an extra week). If time continues to be a
> barrier for review/input, please do speak up.
>
>
> Josh Elser wrote:
>
>> Folks,
>>
>> This is a vote to (rebase and) merge the branch HBASE-16961 into master.
>> Per the book, this requires 3 binding +1's from other committers to merge.
>>
>> Relevant info for those who want to revisit any topics:
>>
>> DISCUSS on merge[1]
>> Design Doc[2]
>> Staged user manual[3]
>>
>> I'll plan to leave this open for at least 72hrs of the work days
>> (Wednesday May 10th EOD) in case there are any vetos. I would prefer to
>> abstain from voting on my own feature and plan to do so if the votes are
>> otherwise lacking.
>>
>> - Josh
>>
>> [1]
>> https://lists.apache.org/thread.html/a28c69bff315a791b9f7b94
>> 6636446a60bd2ddc8d5a9f5c11c2bf6f4@%3Cdev.hbase.apache.org%3E
>>
>> [2] http://home.apache.org/~elserj/hbase/FileSystemQuotasforApac
>> heHBase.pdf
>> [3] https://people.apache.org/~elserj/hbase/quotas/book.html#space-quotas
>>
>
Re: [VOTE] Merge space quota branch (HBASE-16961) into master
Posted by Josh Elser <el...@apache.org>.
As requested (later in this thread), I'll make sure this VOTE stays open
at least until 2017-05-17 (an extra week). If time continues to be a
barrier for review/input, please do speak up.
Josh Elser wrote:
> Folks,
>
> This is a vote to (rebase and) merge the branch HBASE-16961 into master.
> Per the book, this requires 3 binding +1's from other committers to merge.
>
> Relevant info for those who want to revisit any topics:
>
> DISCUSS on merge[1]
> Design Doc[2]
> Staged user manual[3]
>
> I'll plan to leave this open for at least 72hrs of the work days
> (Wednesday May 10th EOD) in case there are any vetos. I would prefer to
> abstain from voting on my own feature and plan to do so if the votes are
> otherwise lacking.
>
> - Josh
>
> [1]
> https://lists.apache.org/thread.html/a28c69bff315a791b9f7b946636446a60bd2ddc8d5a9f5c11c2bf6f4@%3Cdev.hbase.apache.org%3E
>
> [2] http://home.apache.org/~elserj/hbase/FileSystemQuotasforApacheHBase.pdf
> [3] https://people.apache.org/~elserj/hbase/quotas/book.html#space-quotas
Re: [VOTE] Merge space quota branch (HBASE-16961) into master
Posted by Josh Elser <el...@apache.org>.
Since we're struggling to get votes cast (I can only assume due to lack
of time from individuals since there have been no objections/concerns
raised).
Here's my +1 too
Josh Elser wrote:
> Folks,
>
> This is a vote to (rebase and) merge the branch HBASE-16961 into master.
> Per the book, this requires 3 binding +1's from other committers to merge.
>
> Relevant info for those who want to revisit any topics:
>
> DISCUSS on merge[1]
> Design Doc[2]
> Staged user manual[3]
>
> I'll plan to leave this open for at least 72hrs of the work days
> (Wednesday May 10th EOD) in case there are any vetos. I would prefer to
> abstain from voting on my own feature and plan to do so if the votes are
> otherwise lacking.
>
> - Josh
>
> [1]
> https://lists.apache.org/thread.html/a28c69bff315a791b9f7b946636446a60bd2ddc8d5a9f5c11c2bf6f4@%3Cdev.hbase.apache.org%3E
>
> [2] http://home.apache.org/~elserj/hbase/FileSystemQuotasforApacheHBase.pdf
> [3] https://people.apache.org/~elserj/hbase/quotas/book.html#space-quotas