You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/01/03 03:31:00 UTC

[jira] [Work logged] (GOBBLIN-1349) Limit publish to docker repo to only released code

     [ https://issues.apache.org/jira/browse/GOBBLIN-1349?focusedWorklogId=530327&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-530327 ]

ASF GitHub Bot logged work on GOBBLIN-1349:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Jan/21 03:30
            Start Date: 03/Jan/21 03:30
    Worklog Time Spent: 10m 
      Work Description: abti opened a new pull request #3188:
URL: https://github.com/apache/incubator-gobblin/pull/3188


   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1349
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if applicable):
   To publish docker image at release only, and tag with latest and version
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   NA
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 530327)
    Remaining Estimate: 0h
            Time Spent: 10m

> Limit publish to docker repo to only released code
> --------------------------------------------------
>
>                 Key: GOBBLIN-1349
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1349
>             Project: Apache Gobblin
>          Issue Type: Task
>            Reporter: Abhishek Tiwari
>            Assignee: Abhishek Tiwari
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently: 
>  # Each PR push triggers a publish to docker, this is unreleased code. Remove that.
>  # Each released code is published to docker (recent contribution by William, so no released tags are published so far), this is acceptable. Retain this. 
>  # Determine what is an acceptable way for any CI/CD related docker images (review other projects and check with Infra)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)