You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/01/08 02:48:33 UTC

[GitHub] [tvm] masahi edited a comment on pull request #7229: Fix Get Valid Counts when the number of boxes is zero

masahi edited a comment on pull request #7229:
URL: https://github.com/apache/tvm/pull/7229#issuecomment-756513178


   This is not important, but I'd suggest swapping the outer most `then block` and `else block` (`with ib.if_scope(num_anchors == 0):`), since the else block is so far apart and hard to read.
   
   You don't have to do that change, maybe I can do that for my scan PR. 
   
   @trevor-m @anijain2305 Does this solve your issue?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org