You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/10/13 08:25:26 UTC

[GitHub] [skywalking-cli] kezhenxu94 commented on a change in pull request #67: Update release doc

kezhenxu94 commented on a change in pull request #67:
URL: https://github.com/apache/skywalking-cli/pull/67#discussion_r503757132



##########
File path: docs/How-to-release.md
##########
@@ -1,34 +1,45 @@
-# Apache SkyWalking release guide
+# Apache SkyWalking CLI release guide
 
-This documentation guides the release manager to release the SkyWalking CLI in the Apache Way, and also helps people to
-check the release for vote.
+This documentation guides the release manager to release the SkyWalking CLI in the Apache Way, and also helps people to check the release for vote.
 
-## Add your GPG public key
+## Prerequisites
 
-1. Add your GPG public key into [SkyWalking GPG KEYS](https://dist.apache.org/repos/dist/release/skywalking/KEYS) file,
-you can do this only if you are a committer, use your Apache id and password to log into the svn, and update the file.
-**DO NOT override the existed `KEYS` file.**
+1. Clear all milestone issues from [skywalking-cli](https://github.com/apache/skywalking-cli/milestones) and [skywalking](https://github.com/apache/skywalking/milestones), create a new one if needed.

Review comment:
       ```suggestion
   1. Close(if finished, or move to next milestone otherwise) all issues in the current milestone from [skywalking-cli](https://github.com/apache/skywalking-cli/milestones) and [skywalking](https://github.com/apache/skywalking/milestones), create a new milestone if needed.
   ```

##########
File path: docs/How-to-release.md
##########
@@ -1,34 +1,45 @@
-# Apache SkyWalking release guide
+# Apache SkyWalking CLI release guide
 
-This documentation guides the release manager to release the SkyWalking CLI in the Apache Way, and also helps people to
-check the release for vote.
+This documentation guides the release manager to release the SkyWalking CLI in the Apache Way, and also helps people to check the release for vote.
 
-## Add your GPG public key
+## Prerequisites
 
-1. Add your GPG public key into [SkyWalking GPG KEYS](https://dist.apache.org/repos/dist/release/skywalking/KEYS) file,
-you can do this only if you are a committer, use your Apache id and password to log into the svn, and update the file.
-**DO NOT override the existed `KEYS` file.**
+1. Clear all milestone issues from [skywalking-cli](https://github.com/apache/skywalking-cli/milestones) and [skywalking](https://github.com/apache/skywalking/milestones), create a new one if needed.
+2. Update [CHANGES.md](../CHANGES.md).
+
+
+## Add your GPG public key to Apache svn
+
+1. Upload your GPG public key to a public GPG site, such as [MIT's site](http://pgp.mit.edu:11371/). 
+
+1. Log in [id.apache.org](https://id.apache.org/) and submit your key fingerprint.
+
+1. Add your GPG public key into [SkyWalking GPG KEYS](https://dist.apache.org/repos/dist/release/skywalking/KEYS) file, **you can do this only if you are a PMC member**.  You can ask a PMC member for help. **DO NOT override the existed `KEYS` file.**

Review comment:
       ```suggestion
   1. Add your GPG public key into [SkyWalking GPG KEYS](https://dist.apache.org/repos/dist/release/skywalking/KEYS) file, **you can do this only if you are a PMC member**.  You can ask a PMC member for help. **DO NOT override the existed `KEYS` file content, only append your key at the end of the file.**
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org