You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/11/10 22:11:19 UTC
[GitHub] [lucene] benwtrent opened a new pull request, #11919: Follow up to GITHUB#11916, remove deleted docs check
benwtrent opened a new pull request, #11919:
URL: https://github.com/apache/lucene/pull/11919
There is a chance that all the docs are deleted. This is ok in a checkindex scenario and other checks don't bother with verifying deleted docs like this.
Removing the check.
This reproduce line failed before this commit:
```
./gradlew test --tests TestLucene94HnswVectorsFormat.testRandomBytes -Dtests.seed=45F1ECAB3ABC3C78 -Dtests.badapples=true -Dtests.locale=es-BO -Dtests.timezone=America/Fortaleza -Dtests.asserts=true -Dtests.file.encoding=UTF-8
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #11919: Follow up to GITHUB#11916, remove deleted docs check
Posted by GitBox <gi...@apache.org>.
rmuir commented on PR #11919:
URL: https://github.com/apache/lucene/pull/11919#issuecomment-1310970223
looks good, thank you for making the PR so fast. The test failure reproduces and with this change it passes again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir merged pull request #11919: Follow up to GITHUB#11916, remove deleted docs check
Posted by GitBox <gi...@apache.org>.
rmuir merged PR #11919:
URL: https://github.com/apache/lucene/pull/11919
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] benwtrent commented on pull request #11919: Follow up to GITHUB#11916, remove deleted docs check
Posted by GitBox <gi...@apache.org>.
benwtrent commented on PR #11919:
URL: https://github.com/apache/lucene/pull/11919#issuecomment-1310971424
Ran
```
./gradlew test --tests TestLucene94HnswVectorsFormat -Dtests.iters=1000
```
Just to be sure we are good. All green locally.
@rmuir
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] benwtrent commented on pull request #11919: Follow up to GITHUB#11916, remove deleted docs check
Posted by GitBox <gi...@apache.org>.
benwtrent commented on PR #11919:
URL: https://github.com/apache/lucene/pull/11919#issuecomment-1310971694
Apologies for the noise! Still learning all of Lucene's edges :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org