[jira] [Commented] (CALCITE-1581) UDTF like in hive

["Julian Hyde (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854364#comment-16854364 ] 

Julian Hyde commented on CALCITE-1581:
--------------------------------------

At a high level it gets things right, but the code still feels a bit messy.
* I was irked by inconsistent capitalization of "select", "Select", "SELECT" in comments, and "Table Function" with initcaps.
* The "handle..." method works in a mysterious way. Perhaps it writes into an IdentityHashMap, perhaps not.
* The validator test ought to check that table functions are rejected even if they don't use the 'as (...)' syntax.
* We put ')' at the end of lines, never the start.

> UDTF like in hive
> -----------------
>
>                 Key: CALCITE-1581
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1581
>             Project: Calcite
>          Issue Type: New Feature
>            Reporter: Xiaoyong Deng
>            Assignee: pengzhiwei
>            Priority: Major
>              Labels: pull-request-available, udtf
>             Fix For: 1.20.0
>
>          Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> Support one row in and multi-column/multi-row out(one-to-many mapping), just like udtf in hive.
> The query would like this:
> {code}
> select
>   func(c0, c1) as (f0, f1, f2)
> from table_name;
> {code}
> c0 and c1 are 'table_name' columns. f0, f1 and f2 are new generated columns.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)