[jira] Issue Comment Edited: (CASSANDRA-625) Migrate to slf4j from log4j in cassandra code

["Eric Evans (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12843147#action_12843147 ] 

Eric Evans edited comment on CASSANDRA-625 at 3/9/10 3:29 PM:
--------------------------------------------------------------

> so cassandra deployments could use any of the underlying slf4j adapters for ease of integration with existing code without going into multiple loggers madness. We, for example, prefer logback ( http://logback.qos.ch/ ). 

No expert here, but it was my understanding that this was the general reasoning behind slf4j.

      was (Author: urandom):
    > so cassandra deployments could use any of the underlying slf4j adapters for ease of integration with existing code without going into multiple loggers madness. We, for example, prefer logback ( http://logback.qos.ch/ ). 

No expert here, but it was my understanding that this was the general reasoning for behind slf4j.
  
> Migrate to slf4j from log4j in cassandra code
> ---------------------------------------------
>
>                 Key: CASSANDRA-625
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-625
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>         Environment: all
>            Reporter: gabriele renzi
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: CASSANDRA-625.patch
>
>
> currently code generated from thrift uses slf4j while cassandra uses raw log4j. 
> There are various level in which this can be changed: 
> * simply switch log4j loggers with slf4j logger (done in patch)
> * replacing log4j-isms (e.g. string concatenation+isFooEnabled in all code paths) with slf4j-isms (marker string + additional arguments)
> * remove code that is already available for lsf4j (LogUtils.java, I believe is unnecessary)
> I am posting this as a reminder, I have a half baked patch locally but it needs more work 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.