[GitHub] [netbeans] lahodaj commented on a diff in pull request #4671: add semantic highlight for when keyword

[GitBox <gi...@apache.org>]

lahodaj commented on code in PR #4671:
URL: https://github.com/apache/netbeans/pull/4671#discussion_r991858557


##########
java/java.editor.base/src/org/netbeans/modules/java/editor/base/semantic/SemanticHighlighterBase.java:
##########
@@ -657,6 +658,18 @@ public Void visitRequires(RequiresTree tree, Void p) {
             return super.visitRequires(tree, p);
         }
 
+        @Override
+        public Void visitBindingPattern(BindingPatternTree node, Void p) {

Review Comment:
   I believe `when` is part of the `case` structure, not the binding pattern structure. Shouldn't the detection of the contextual keyword be in `visitCase`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists